Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GHC 9.2 for all packages #1555

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Allow GHC 9.2 for all packages #1555

merged 4 commits into from
Mar 21, 2022

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Mar 8, 2022

Fixes #1496.

This is an alternative to #1482 that just needs a single additional allow-newer. Instead of overriding dependencies, this simply marks packages as unbuildable if they haven't been updated for GHC 9.2 yet (e.g. due to Cryptonite). This still allows many packages to add compatibility, and it is verified in CI that it compiles. By using buildable: False instead of e.g. base bounds, we can continue listing all projects in cabal.project, and cabal-install will not complain if a project can't be built. EDIT: Now adds all packages except one cook book, since Cryptonite was updated.

I haven't added a Stack build because I think it makes most sense to use Stackage snapshots are they are, instead of e.g. replacing the compiler version. There is still no snapshot with GHC 9.2.2.

I haven't added the Nix configuration, since as far as I can see, Nixpkgs hasn't made a tag with GHC 9.2.2 yet. But I'd be happy to add that in a later PR when such a release becomes available.

For now, I think that this provides a reasonable improvement for users and no notable dependency burden.

@ysangkok ysangkok mentioned this pull request Mar 9, 2022
@ysangkok ysangkok changed the title Allow GHC 9.2 for compatible packages Allow GHC 9.2 for ~compatible~all packages Mar 14, 2022
@ysangkok ysangkok changed the title Allow GHC 9.2 for ~compatible~all packages Allow GHC 9.2 for ~compatible~ all packages Mar 14, 2022
@ysangkok ysangkok changed the title Allow GHC 9.2 for ~compatible~ all packages Allow GHC 9.2 for ~~compatible~~ all packages Mar 14, 2022
@ysangkok ysangkok changed the title Allow GHC 9.2 for ~~compatible~~ all packages Allow GHC 9.2 for all packages Mar 14, 2022
@maksbotan maksbotan merged commit 89b66a3 into haskell-servant:master Mar 21, 2022
@maksbotan
Copy link
Contributor

Published https://hackage.haskell.org/package/servant-server-0.19.1 with 9.2 fixes, updated the rest of packages with revisions.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build on ghc 9.2.1
2 participants