Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow GHC 8.4.1 #922

Closed
wants to merge 1 commit into from
Closed

Allow GHC 8.4.1 #922

wants to merge 1 commit into from

Conversation

jkarni
Copy link
Member

@jkarni jkarni commented Mar 13, 2018 

And include it in the travis build matrix.
Also includes fixes for a couple of typos and copyright dates in
cabal files.

@jkarni
Allow GHC 8.4.1
7929db5 
    And include it in the travis build matrix.
    Also includes fixes for a couple of typos and copyright dates in
    cabal files.
@alpmestan alpmestan requested a review from phadej March 13, 2018 09:21
@jkarni
Copy link
Member Author

jkarni commented Mar 13, 2018

There blaze-builder doesn't support GHC 8.4.1 yet. Let's rerun when the linked issue is fixed.

@DanBurton
Copy link
Contributor

Note that blaze-builder-0.4.1.0 has been released, which does support ghc 8.4.1.

@jkarni
Copy link
Member Author

jkarni commented Mar 15, 2018

@DanBurton thanks!

Looks like now it's postgresql-simple that still needs to bump its base upper bound

@phadej
Copy link
Contributor

phadej commented Mar 15, 2018

This looks good. See servant-foreign change in #925

Note we are also blocked on zmthy/http-media#25

@alpmestan
Copy link
Contributor

Are we still blocked on other things?

@phadej
Copy link
Contributor

phadej commented May 2, 2018

lpsmith/postgresql-simple#252

@phadej
Copy link
Contributor

phadej commented Jun 1, 2018

master has GHC-8.4.3 in travis now. Sorry it took so long :/

@phadej phadej closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phadej phadej Awaiting requested review from phadej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkarni @DanBurton @phadej @alpmestan