Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template-haskell-2.21 (GHC-9.8) #484

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Allow template-haskell-2.21 (GHC-9.8) #484

merged 1 commit into from
Oct 10, 2023

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Oct 10, 2023

Update CI: add GHC-9.6 and GHC-9.8 jobs, bump minor version of recent GHCs

Looks like revision 2 https://hackage.haskell.org/package/unordered-containers-0.2.19.1/revisions/ was never merged in. I cannot find an issue or pull request, @andreasabel?

Update CI: add GHC-9.6 and GHC-9.8 jobs, bump minor version of recent
GHCs

Looks like revision 2 https://hackage.haskell.org/package/unordered-containers-0.2.19.1/revisions/
was never merged in. I cannot find an issue or pull request.
@phadej phadej changed the title Allow template-haskell-2.21 Allow template-haskell-2.21 (GHC-9.8) Oct 10, 2023
@treeowl treeowl merged commit 51d0709 into master Oct 10, 2023
10 checks passed
@treeowl treeowl deleted the ghc-9.8 branch October 10, 2023 12:20
@treeowl
Copy link
Collaborator

treeowl commented Oct 10, 2023

Thanks!

@andreasabel
Copy link

Looks like revision 2 https://hackage.haskell.org/package/unordered-containers-0.2.19.1/revisions/ was never merged in. I cannot find an issue or pull request, @andreasabel?

Indeed, I cannot find any either.
Sorry, this is more than half a year ago, I do not have any recollection of this.

@andreasabel andreasabel mentioned this pull request Oct 10, 2023
3 tasks
@phadej
Copy link
Contributor Author

phadej commented Oct 10, 2023

@treeowl thanks. Could you make a revision (or a release including #482 e.g.)

@andreasabel
Copy link

@treeowl @phadej Is there any reason to delay the revision? This package has tons of customers, and any delay multiplies accordingly. So, I would make the revision now.

@phadej
Copy link
Contributor Author

phadej commented Oct 12, 2023

@andreasabel I'm not a maintainer of unordered-containers. They are @treeowl and @sjakobi

EDIT: The GitHub "member" tag shows that I'm member of an organization, and it is often misleading, as it is here.

@andreasabel
Copy link

Ok, I did revision 3: https://hackage.haskell.org/package/unordered-containers-0.2.19.1/revisions/ relative to cabal get unordered-containers. The master has some additional commits, so cannot serve as a revision base atm.
I suppose the maintainers want to make a release soon, but having the revision out sooner rather than later helps the Haskell ecosystem to move forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants