Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate _qualified_ imports to avoid clashes with user code #259

Merged
merged 6 commits into from
Feb 29, 2024
Merged

Generate _qualified_ imports to avoid clashes with user code #259

merged 6 commits into from
Feb 29, 2024

Commits on Feb 27, 2024

  1. Drop code generation for GHCs < 6.4 (removing some #ifs) 

    These have been untested since long.
    @andreasabel
    andreasabel committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    06b8f3d View commit details
    Browse the repository at this point in the history

  2. Qualified import of GHC.Exts in generated code 

    We can import the identifiers with `#` supported by all GHC versions
unqualified from `GHC.Exts`, not expecting any clash with user code.

Identifiers that are only known in newer versions of GHC, in
conditional code, are referred to qualified, e.g. `GHC.Exts.foo`.
    @andreasabel
    andreasabel committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    33ef72a View commit details
    Browse the repository at this point in the history

  3. Qualified import of Debug.Trace in generated code

    @andreasabel
    andreasabel committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ebf21a9 View commit details
    Browse the repository at this point in the history

  4. Qualified import of Data.Array in generated code

    @andreasabel
    andreasabel committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c14f8b5 View commit details
    Browse the repository at this point in the history

  5. Test for #258: provoke clash with GHC.Exts.Symbol

    @andreasabel
    andreasabel committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a335798 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Bump to v3.5.1.0; CHANGELOG; update CI to GHC 9.8.2

    @andreasabel
    andreasabel committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    f8fe5f0 View commit details
    Browse the repository at this point in the history