Drop outdated comment #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lazy `lines` function has not been `too` strict for some time now. The issue was resolved a day or so after the comment was added, but the comment was inadvertently left behind.
Bodigrim
reviewed
Nov 25, 2020
| > prop_lazy = | ||
| (L.unpack . head . lazylines $ L.append (L.pack "a\nb\n") (error "failed")) | ||
| == | ||
| "a" |
There was a problem hiding this comment.
Could we possibly add this to the test suite?
There was a problem hiding this comment.
Can I ask someone else to pitch in?
There was a problem hiding this comment.
I am a bit reluctant to backport two commits to bytestring-0.11 branch, when we can make do with one. Please just add
prop_lines_lazy = head (LC.lines (LC.append (LC.pack "a\nb\n") undefined)) == LC.pack "a"to Properties.hs and mention prop_lines_lazy in ll_tests, that's it.
, testProperty "lines_lazy" prop_lines_lazy
Bodigrim
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Drop outdated comment The Lazy `lines` function has not been `too` strict for some time now. The issue was resolved a day or so after the comment was added, but the comment was inadvertently left behind. * Add lazy `lines` non-strictness test Co-authored-by: Viktor Dukhovni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Lazy
linesfunction has not beentoostrict for sometime now. The issue was resolved a day or so after the comment
was added, but the comment was inadvertently left behind.