Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type ByteStringBuilder = Builder #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BebeSparkelSparkel
Copy link
Contributor

No description provided.

@clyring
Copy link
Member

clyring commented Apr 13, 2024

Why do you want this, exactly?

@Bodigrim
Copy link
Contributor

It makes sense to me, to distinguish from other Builders in the ecosystem.

@BebeSparkelSparkel
Copy link
Contributor Author

@clyring I have been using Data.ByteString.Builder.Builder and Data.Text.Lazy.Builder.Builder in a lot of my tests.

I also did a search https://github.com/search?q=%22type+ByteStringBuilder%22+language%3AHaskell&type=code&ref=advsearch and found that many packages are defining this internally, so it makes sense to export it so they all can have a common reference.

@BebeSparkelSparkel
Copy link
Contributor Author

@Bodigrim Is this a consideration for bytestring as well? haskell/text#581 (comment)

@Bodigrim
Copy link
Contributor

Not necessarily, there is no strict ByteString builder directly in bytestring.

Naming is hard, sigh.

@BebeSparkelSparkel
Copy link
Contributor Author

Is there potential to be? If not, this is ready.

@BebeSparkelSparkel
Copy link
Contributor Author

If a strict builder is ever added, we can add the variants then.

@BebeSparkelSparkel
Copy link
Contributor Author

@clyring Solved merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants