Skip to content

Commit

Permalink
Just don't bother supporting Custom at this point
Browse files Browse the repository at this point in the history
Signed-off-by: Edward Z. Yang <[email protected]>
  • Loading branch information
ezyang committed Aug 2, 2016
1 parent ebecaa9 commit 4e1e408
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions cabal-install/Distribution/Client/ProjectPlanning.hs
Original file line number Diff line number Diff line change
Expand Up @@ -1051,8 +1051,17 @@ elaborateInstallPlan platform compiler compilerprogdb
CD.ComponentExe _ -> True
_ -> False
eligible
-- TODO
-- At this point in time, only non-Custom setup scripts
-- are supported. Implementing per-component builds with
-- Custom would require us to create a new 'ElabSetup'
-- type, and teach all of the code paths how to handle it.
-- Once you've implemented that, delete this guard.
| fromMaybe PD.Custom (PD.buildType pd) == PD.Custom
= False
-- Only non-Custom or sufficiently recent Custom
-- scripts can be expanded.
| otherwise
= (fromMaybe PD.Custom (PD.buildType pd) /= PD.Custom
-- This is when we started distributing dependencies
-- per component (instead of glomming them altogether
Expand All @@ -1067,6 +1076,7 @@ elaborateInstallPlan platform compiler compilerprogdb
, benchmarksEnabled = True }
internalPkgSet = pkgInternalPackages pkg
comps_graph = Cabal.mkComponentsGraph enabled pd internalPkgSet

buildComponent :: Map ComponentName ConfiguredId
-> (Cabal.Component, [Cabal.ComponentName])
-> (Map ComponentName ConfiguredId, ElaboratedComponent)
Expand Down

0 comments on commit 4e1e408

Please sign in to comment.