Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cabal external command requires typing Return to exit #10063

Closed
wismill opened this issue May 31, 2024 · 1 comment · Fixed by #10100
Closed

Cabal external command requires typing Return to exit #10063

wismill opened this issue May 31, 2024 · 1 comment · Fixed by #10100
Labels
cabal-install: cmd/external-cmd type: bug

Comments

@wismill
Copy link
Collaborator

wismill commented May 31, 2024

Describe the bug
When using cabal external command feature, the program does not exit until typing Return.

To Reproduce
Steps to reproduce the behavior:

  • Install cabal-doctest (new proposed doctest feature)
  • Try e.g. cabal help doctest, or try cabal doctest on a package with doc to test.

Expected behavior
The program should exit normally without requiring typing Return.

System information

  • Linux
  • cabal: master
  • ghc: 9.2, 9.4, 9.8

Additional context
Discovered while working on #10057 (see comment) and sol/doctest#424
@wismill wismill changed the title Cabal external require typing Return to exit Cabal external command requires typing Return to exit May 31, 2024
mpickering added a commit to mpickering/cabal that referenced this issue Jun 10, 2024
@mpickering
external commands: Wait for process to finish before exiting
f0884a1 
Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
@mpickering mpickering mentioned this issue Jun 10, 2024
Merged
mpickering added a commit to mpickering/cabal that referenced this issue Jun 10, 2024
@mpickering
external commands: Wait for process to finish before exiting
88e8777 
Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
mpickering added a commit to mpickering/cabal that referenced this issue Jun 10, 2024
@mpickering
external commands: Wait for process to finish before exiting
9e8bd59 
Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
geekosaur pushed a commit to mpickering/cabal that referenced this issue Jun 11, 2024
@mpickering @geekosaur
external commands: Wait for process to finish before exiting
0eda149 
Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
@mpickering
Copy link
Collaborator

I have fixed this in #10100

ulysses4ever pushed a commit to mpickering/cabal that referenced this issue Jun 14, 2024
@mpickering @ulysses4ever
external commands: Wait for process to finish before exiting
054e2e3 
Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
@mergify mergify bot closed this as completed in #10100 Jun 14, 2024
@mergify mergify bot closed this as completed in cb57c37 Jun 14, 2024
mergify bot pushed a commit that referenced this issue Jun 14, 2024
@mpickering @mergify
external commands: Wait for process to finish before exiting (#10100)
df46ecd 
Issue #10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes #10063

(cherry picked from commit cb57c37)
@mergify mergify bot mentioned this issue Jun 14, 2024
Merged
mergify bot added a commit that referenced this issue Jun 14, 2024
@mergify @mpickering
external commands: Wait for process to finish before exiting (#10100) (…
4889c6b 
…#10116)

Issue #10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes #10063

(cherry picked from commit cb57c37)

Co-authored-by: Matthew Pickering <[email protected]>
erikd pushed a commit to erikd/cabal that referenced this issue Jun 17, 2024
@mpickering @erikd
external commands: Wait for process to finish before exiting (haskell…
388f9cb 
…#10100)

Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
mmhat pushed a commit to mmhat/cabal that referenced this issue Jun 24, 2024
@mpickering @mmhat
external commands: Wait for process to finish before exiting (haskell…
c3432b1 
…#10100)

Issue haskell#10063 points out that cabal exits before the external command
has finished executing. This was a simple oversight to not
waitForProcess on the result of calling createProcess.

This also points out the flaw that there isn't a way for external
commands to signal failure, so we now also propagate the exit code from
the external process.

Fixes haskell#10063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cabal-install: cmd/external-cmd type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

external commands: Wait for process to finish before exiting mpickering/cabal
2 participants
@mpickering @wismill