Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allBuildInfo does not include foreign library dependencies #4763

Closed
snoyberg opened this issue Sep 13, 2017 · 5 comments
Closed

allBuildInfo does not include foreign library dependencies #4763

snoyberg opened this issue Sep 13, 2017 · 5 comments

Comments

@snoyberg
Copy link
Collaborator

This may be a misunderstanding on my part, I'm not familiar with foreign libraries outside of the type ForeignLib itself. But it appears that:

  • A ForeignLib can introduce dependencies on packages
  • The allBuildInfo function will not return the BuildInfo values within ForeignLibs

It seems like this means we will not necessarily track dependencies from ForeignLibs. Is this intentional?

@23Skidoo
Copy link
Member

/cc @ezyang @edsko

snoyberg added a commit to commercialhaskell/stack that referenced this issue Sep 13, 2017
This should resolve both #3364 and #3361. There is a test case included
that should address both of them as well.

This is still relatively hacky. We will eventually be overhauling the
component system more dramatically to support Backpack with #2540 (CC
@ezyang).

This may still have some problems due to the upstream issue
haskell/cabal#4763, but at least in theory we're matching the behavior
of upstream. We can consider workarounds after that issue comes to a
conclusion.
snoyberg added a commit to commercialhaskell/stack that referenced this issue Sep 13, 2017
@snoyberg
Copy link
Collaborator Author

I've introduced a modified version of allBuildInfo in Stack to work around this:

commercialhaskell/stack@8f61b8c

If you look in that commit, you'll see a modification to an integration test (adding a foreign library dependency on the mtl package). Without the allBuildInfo' change, this causes an error when building. Note that I also tested cabal-install-2.0.0.0 with both the install and new-build commands. Both of them installed mtl. So it appears to me at least that cabal-install has a different dependency tracking mechanism than allBuildInfo.

@ezyang
Copy link
Contributor

ezyang commented Sep 13, 2017

This is a straight up bug in allBuildInfo and we should fix it.

@snoyberg
Copy link
Collaborator Author

snoyberg commented Sep 13, 2017 via email

snoyberg added a commit that referenced this issue Sep 13, 2017
Include foreign libs in allBuildInfo (fixes #4763)
23Skidoo pushed a commit that referenced this issue Sep 13, 2017
@23Skidoo
Copy link
Member

Also backported into the 2.0 branch.

clrpackages pushed a commit to clearlinux-pkgs/stack that referenced this issue Jan 3, 2018
Aaron McDaid (1):
      Don't put ':' into the copyright message. It breaks 'stack new' by causing an error 'simple/package.yaml:6:30: mapping values are not allowed in this context'

Adam McCullough (1):
      Fix docker comment (#3402)

Alexey Zabelin (2):
      Improve `stack upgrade --help` documentation
      Update ChangeLog

Andy (1):
      get-stack.sh linux mint support

Ashley Towns (1):
      minor documentation update, --no-executable-stripping

Chris Done (2):
      Build all exes once; then only specified (#3229)
      Include package name in exes message (#3229)

Chris Martin (1):
      mention hpack a bit more in the docs

Deni Bertovic (1):
      Adds integration test for #3396

Dmitry Ivanov (1):
      Remove the hope of getting stack into travis build via apt

Echo Nolan (1):
      Fix handling of missing image message with newer versions of Docker

Emanuel Borsboom (60):
      Merge branch 'rc/v1.5.0'
      Fix merge mistake
      stack.cabal: bump to version 1.5.1
      Merge remote-tracking branch 'origin/stable'
      Merge branch 'stable'
      Dockerfile and CI for LTS-9 Docker images
      get-stack: create destination directory if missing (fixes #3208)
      Merge branch 'stable'
      Merge pull request #3343 from rdnetto/master
      Merge pull request #3366 from lwm/fixup-3350
      gitlab-ci: upgrade to newer build image
      Integration tests: fix warnings in StackTest.hs
      Add 'not for released version' warning to docs source (#3410)
      Merge pull request #3411 from commercialhaskell/3410-docs-warning
      Fix mkdocs search hack.
      Merge pull request #3415 from commercialhaskell/3376-fix-search
      gitlab-ci.yml: bump image
      Merge pull request #3490 from andys8/patch-1
      stack.cabal: bump version to 1.6.0.20171017
      Merge remote-tracking branch 'origin/stable' into prerelease/v1.6.0.20171017
      stack*.yaml: bump snapshot versions
      Merge branch 'prerelease/v1.6.0.20171017'
      stack.cabal: bump to version 1.6.0
      etc/scripts/stack.yaml: bump resolver
      stack-nightly.yaml: remove mintty flags since nightly has new Win32
      Add 'supported-build' flag
      Use hpack package.yaml to build Stack
      Add etc/scripts/package.yaml
      etc/scripts/release.hs: ensure stack.cabal generated
      Merge remote-tracking branch 'origin/stable'
      stack*.yaml: bump to latest snapshots
      Fix build warnings on Windows
      Fix integration test 3396-package-indices on Windows
      Ignore new warnings in hlint-2.0.10
      Move hlint.sh to etc/scrpts
      Explicitly set STACK_ROOT in integration tests
      Shorten integration tests' home directory path
      Fix warning in IntegrationSpec.hs
      Bump integration tests snapshot to match stack's
      Changelog: add release note about --pvp-bounds
      Fix integration test build warning
      ChangeLog: v1.6
      ChangeLog: move misplaced items to v1.6.1
      ISSUE_TEMPLATE: bump current stack version
      package.yaml: version 1.6.0.20171202
      ChangeLog: remove duplicate note about --pvp-bounds
      test/integration: all tests use ghc-8.0.2
      package.yaml: version 1.6.0
      package.yaml: add package.yaml to extra-source-files
      Merge remote-tracking branch 'origin/stable' into rc/v1.6.1
      package.yaml: v1.6.1
      ansi-terminal-0.7.1.1
      Fix internal-libraries integration test
      package.yaml: v1.6.2
      install_and_upgrade.md: note about Windows Defender warning for installers
      Compatible with unliftio-0.2.1.0 and smallcheck-1.1.3
      Merge branch 'release' into stable
      Changelog: Add v1.6.1.1
      Ignore stack patchlevel for doc links and docker exe dl
      v1.6.3

Felix Yan (8):
      Allow errors 2.2
      Fix build with path 0.6.1
      Fix a typo: transfering -> transferring
      Allow cryptonite 0.24 and path 0.6
      Use path-0.6
      Allow extra 1.6
      Fix a typo in Setup.hs
      Support conduit-extra 1.2.0

Filippo Vitale (1):
      Update GUIDE.md

Gábor Lipták (1):
      Bring Stack version message current in Github template

Ivan Lazar Miljenovic (1):
      Fix up Using Cabal file section

Joshua Simmons (66):
      in newer GHC, turn on the color flag for colored error output and etc.
      use stack's color setting to choose if we should tell GHC to color
      add note to changelog about GHC color output
      factor out the GHC color flag stuff for use in other places
      let GHC colors show through from stack script as well
      add some help for a confusing error when you have no LICENSE file
      fix fetching configs (use newer lens way) in bindirCompilerTools
      create integration test for 2643-copy-compiler-tool
      try to account for windows with exe extensions
      improve 2643 integration test, better checks of correctness
      try prettying up the output from `stack uninstall`
      pretty up the errors from `stack upload`
      fix wording of stack upload error
      use more semantic color names
      standardize how $pretty* stuff is aligned after labels
      pretty up a couple of warnings
      create some utility variants of $pretty* functions, and use them
      give `wordDoc` a more intuitive name (`wordDocs`)
      introduce convenience function for `fillSep . wordDocs`
      try out using `flow` in a few places in a hopefully sane form
      improve repetition in $pretty* function definitions
      be more generic about what we're styling semantically
      avoid having specialized functions for `style* . display`
      use better style for the pretty errors for `stack upload`
      $pretty up a $logInfo
      document some PrettyPrint functions
      remove redundant bracket
      generalize the `pretty*` functions a bit
      pretty up `printCabalFileWarning`
      prepare `s/S/Package` functions for being made pretty
      pretty up some s/S/Package functions
      pretty up the `hpack` function
      add a style for module names
      pretty up `logPossibilities`
      pretty up the last (?) things in `s/S/Package.hs`
      fix compile of callers of `hpack` with too few constraints
      use `display` instead of a custom Path converter
      add a hlint rule for `fromString . toFilePath`
      add a TODO about dispOne in s/S/Package.hs
      ignore 'Use display' hint in Display instance definitions for Path
      Merge pull request #3384 from kadoban/pretty-s-s-package
      create stub `System.Terminal` module
      prepare for protecting windows from POSIX-only term detection
      create type to store C's winsize struct
      implement `getTerminalWidth`
      wrap more stuff in windows check
      require hsc2hs build tool
      make low-level print funcs take terminal width as a param
      add a command-line option to set/override the terminal width
      add the term width stuff to LogOptions
      replace terminal width numbers with named constants
      use the terminal width when pretty-printing
      improve terminal-width min/max behavior
      use a more reasonable minimum terminal width
      fix test compilations due to terminal width
      pin hsc2hs as an extra-dep
      manually force appveyor to install hsc2hs first
      stop trying to use hsc2hs on windows
      document some constants
      add term-width changes to the changelog
      bring back prettyInfoS and prettyDebugS
      pretty up s/S/Upgrade
      add more info to the --help output for new and templates
      apply s/S/Ghci hlint suggestion
      colorize warn output in s/P/CheckInstall
      combine two prettyWarnL calls into one, they're the same message

Judah Jacobson (1):
      Fix #2886: include package names in the haddock index.

Khan Thompson (3):
      Fixes automatically shown versions for licenses #3432
      Implement #3264 adding --cwd to exec
      Changes based on feedback

Lizao Li (1):
      fix: updated solution to `-fPIC` problem

Luke Murphy (12):
      Add test for passing multiple GHC options.
      Fix comment for `check_dest_on_path`.
      Make `has_stack` care about the $DEST argument.
      Bump to latest LTS and drop explicit extra-deps.
      Use HLint 2.
      Remove unused pragmas.
      Install happy for style builds.
      Add mkdocs search hack.
      Merge pull request #3393 from lzlarryli/lzlarryli-fpic-from-stable
      Merge pull request #3434 from OvermindDL1/patch-1
      Ask before saving hackage credentials.
      Use type annotations to avoid warnings in GHCi.

Martin Kolinek (10):
      Added CLI option for skipping
      Skip components in loadLocalPackage
      Added a test
      Also apply skipping of components when targets are specified
      Updated changelog and docs
      Cleaned up test files
      Fixed broken link
      Added a comment to clarify not skipping executables
      Renamed the option to just skip
      Skip now also works for executables - update docs and tests

Mathieu Boespflug (2):
      Map "8.0" to v8.0.2 minor GHC release in --nix config.
      Add a fixMinor clause for "8.2" GHC symbolic version in --nix config.

Matt Audesse (1):
      Merge pull request #3474 from wfranzini/patch-1

Matthias Heinzel (1):
      Fix references to non-existing GitHub issue labels

Michael Sloan (115):
      Use GHCJS_PACKAGE_PATH when copying ghcjs precompiled packages #3277
      Only plan to build a target if some of its components will built #2862
      Fix display of actual hash in verified download
      Install alex and happy if needed before booting ghcjs #3243
      Merge pull request #3303 from schlueter/fix/GUIDE.md-bypass-shell-auto-complete-manual-redirection
      Merge pull request #3286 from chris-martin/pr/doc-hpack
      Make --ghc-options and --ghcjs-boot-options take multiple args #3315
      Have "stack ghci" load modules all at once instead of grouped by pkg #3309
      Add "stack ghci --only-main" flag
      Better stack clean errors #1649
      Merge branch 'master' into multiword-ghc-options
      Merge pull request #3316 from commercialhaskell/multiword-ghc-options
      Better error handling for stack ghci targets parsing #3342
      Use -fprof-auto -fprof-cafs instead of -auto-all -caf-all
      Merge branch 'master' into install-alex-and-happy-for-ghcjs-boot-3243
      Merge pull request #3321 from commercialhaskell/install-alex-and-happy-for-ghcjs-boot-3243
      Clear index cache if it is old #3033
      Implementation of "--copy-compiler-tool" #2643
      Have `stack script` pass absolute source path to `ghc` #3372
      Fix running `stack ghci` with no targets #3309
      Merge pull request #3354 from kadoban/colorfully-messing-with-output
      Improve `stack image container` docs
      Merge branch 'stable'
      Merge pull request #3389 from commercialhaskell/3373-newer-logging
      Fix constraint error for cli extra deps #3378
      Merge pull request #3392 from commercialhaskell/3390-unbuildable-test
      Redownload build plan yaml if it is missing, even if etag is present
      Merge pull request #3405 from SimSaladin/issue-3400
      Merge pull request #3406 from ethercrow/patch-1
      Merge pull request #3395 from kadoban/terminal-detection
      Merge pull request #3421 from phadej/ghc-8.2
      Merge pull request #3433 from TaktInc/nix-gcc
      Merge pull request #3436 from lwm/prompt-creds
      Add indication of which repo is being cloned
      Misc refactoring of parseArgs EscapingMode
      Improve "stack hoogle" messaging for existing installations #3440
      Merge pull request #3404 from commercialhaskell/2650-pretty-upgrade
      Fix testsuite compilation
      When extracting local GHC from tarball on windows, use temp dir #3188
      Drop GHCRTS envvar unless user is asking for execution #3444
      Merge pull request #3450 from mheinzel/fix-github-issue-labels
      Merge pull request #3443 from scott-fleischman/hpack
      Merge pull request #3212 from commercialhaskell/7zip-temp-dir
      Better args help text for stack script / exec / runghc / etc
      Fix computation of new build-cache #3424
      Also run checkForUnlistedFiles for non-target local packages
      Merge pull request #3456 from commercialhaskell/fix-build-cache-3424
      Temporarily remove cabal build variant from travis configuration #3458
      Merge pull request #3457 from khanage/render_license_version_3432
      Improve build plan error text #3438
      Suggest "allow-newer: true" instead of --allow-newer
      Clarify to user that compiler resolvers cause solver use
      Fix "stack clean" with --nix #3468
      Remove a changelog entry
      Merge pull request #3470 from commercialhaskell/fix-nix-stack-clean
      Merge pull request #3477 from sjakobi/faster-init
      Merge pull request #3481 from ivan-m/patch-1
      Merge pull request #3495 from rjmk/revert-construct-plan-logic
      Merge pull request #3497 from khanage/3264-add-cwd-to-exec
      Add ChangeLog entry for #3264
      Merge pull request #3500 from felixonmars/patch-1
      Revert "Make --ghc-options and --ghcjs-boot-options take multiple args #3315"
      Due to revert of fix for #3315, also disable the test.
      Fix a warning
      Fix issue number text in ChangeLog for 1.4.0
      Output explanations when "stack upload" / "stack sdist" have no targets #3504
      Merge pull request #3519 from d-dorazio/master
      Have --pvp-bounds omit constraints on internal libraries #3290
      Merge pull request #3529 from ndmitchell/master
      Fix regression in "stack list-dependencies --license" #3531
      Fix compilation
      Merge pull request #3511 from NorfairKing/retry-info
      Trim some trailing whitespace
      Clarify that git dependencies with non-sha refs affects determinism
      Better word choice
      Merge pull request #3536 from commercialhaskell/3533-extra-deps-solver
      Merge pull request #3538 from aaronmcdaid/stable
      Warn when no targets are used with ghci #3544
      Merge pull request #3547 from commercialhaskell/warn-no-targets-ghci-3544
      Fix printing of --terminal-width in --help #3542
      Add a warning when Cabal file roundtripping fails #3549
      Workaround a bizarre haddock / ghc bug
      Clarify that the Cabal bug is fixed in development version #3549
      Merge pull request #3555 from tswelsh/3552-log-tests-complete
      Add note about #3562 to ChangeLog.md
      Fix stack.yaml docs about flags promoting from snapshot to extra-dep #3564
      Fix "stack setup --upgrade-cabal" #3560
      Better wording: omit instead of suppress
      Clearer error messages when build of Setup.hs fails #3560
      Add a warning when setup-depends does not contain Cabal #3560
      Tweak wording of new setup-depends warning #3560
      Move terminal detection changelog out of behavior change category
      Apply package specific "ghc-options" after more general ones #3573
      Fix a hlint hint
      Misc doc tweaks, clarify how to configure STACK_ROOT
      Merge pull request #3516 from felixonmars/conduit-extra-1.2.0
      yaml_configuration.md coverage for all options
      Remove an unused type
      "stack ghci" now does package hiding when non-local targets are specified
      Merge pull request #3585 from kadoban/templates-new-help
      Merge pull request #3581 from commercialhaskell/add-to-yaml-config-docs
      Merge pull request #3593 from commercialhaskell/only-tweak-cabal-as-necessary
      Fix package-hiding option parsing + always expose base to ghci
      Move unix/ and windows/ into src/
      Fix spacing of build plan errors
      Merge pull request #3596 from commercialhaskell/all-code-in-src
      Merge pull request #3598 from commercialhaskell/3534-run-autoreconf
      Add a note about using `extra-lib-dirs` / `extra-include-dirs` in config.yaml
      Merge pull request #3601 from commercialhaskell/3574-extra-dep-locals
      Merge branch 'master' into drop-ghcrts-env-var
      Merge pull request #3587 from kadoban/even-more-colors
      Word choice in GHCI message when build fails
      Maybe fix integration tests without existing STACK_ROOT #3662
      Clarify "Custom installed GHCJS" section title
      ghcjs.md wording

Michael Snoyman (262):
      Turn on --install-ghc by default
      Remove a bunch of unneeded info from BuildPlan
      Do not store core package info in build plan
      Remove a few more unneeded fields
      Move towards SnapshotDef/ResolvedSnapshot
      Rename Resolved to Loaded
      Remove debugging lines
      Able to load up SnapshotDef and begin LoadedSnapshot
      Introduce PackageIdentifierRevision
      Move from GitSHA1 to SHA256
      A working loadResolver
      Stack.Fetch: lookup with revision
      Implemented Stack.Snapshot
      Compiles again
      Implement checkDepsMet
      Simple scripts work
      Implement most of resolvePackageLocation
      Load snapshots that include non-index files (does not compile)
      Generalize a bit
      Implement global hints
      Move some helpers to the top level
      Begin moving SourceMap to Snapshot logic
      IT BUILDS A PACKAGE!!!
      SinglePackageLocation
      Distinguish actual and wanted compiler at the type level
      More type safety for PackageLocation vs SinglePackageLocation funcs
      Remove unneeded data type RemotePackageType
      MonadUnliftIO
      Clean up LocalPackages
      Fix exception strictness
      Better Show instances for exception
      Split off PackageLocationIndex
      unpackPackageIdent
      Clean up Stack.BuildPlan
      Implement getToolMap (fixes #595)
      Total overhaul of target parsing for extensible snapshots
      Fix a logic bug in upgrading packages
      Some dead code removal
      Clean up warnings and FIXMEs
      Test suite passes!
      More warning and FIXME cleanup
      Defer an error to ConstructPlan
      Remove out-of-date FIXMEs
      A bunch of other FIXME cleanups
      Remove no longer relevant test module
      Fix a warning
      Merge pull request #3241 from felixonmars/fix-typo
      Fix warnings and hlint errors
      subdirs should be optional
      Custom snapshots: add back compiler: support
      stack init: deal with possibly missing fields
      splitUnmetDeps for parent packages too
      Fix sdist
      Allow subdirs of filepaths (cuz why not?)
      Fix broken PackageIdentifierRevision display
      Better upgrade messages
      Fix integration test by bypassing Hackage revisions :(
      FIXME in changelog about extensible snapshots
      Include hash in custom snapshot cache file name
      Disallow PLFilePath in custom snapshots
      Fix compilation failure
      Clean up a warning
      Fix some Haddock markup
      Move custom snapshot name inside the snapshot
      Remove lsResolver
      Allow overriding compiler in custom snapshot
      Merge remote-tracking branch 'origin/master' into extensible-snapshots
      Replace error calls with proper exceptions
      Resolve a bunch of FIXMEs
      Generalize type of runOnce
      Update YAML docs
      Subdirs in HTTP; allow overriding hidden
      Avoid deleting local files (yeah, that is bad)
      Merge pull request #3249 from commercialhaskell/extensible-snapshots
      Merge remote-tracking branch 'origin/exe-targets-3229'
      Merge branch 'use-text-metrics-0.3.0' of https://github.com/mrkkrp/stack
      Merge branch 'patch-2' of https://github.com/felixonmars/stack
      Merge branch 'path-0.6.1' of https://github.com/felixonmars/stack
      Merge pull request #3231 from commercialhaskell/install-ghc-by-default
      Merge branch '3006-speed-up-store-instances' of https://github.com/alexeyzab/stack into alexeyzab-3006-speed-up-store-instances
      Unify on StaticSHA256
      Merge branch 'docker-inspect-update' of https://github.com/enolan/stack
      Merge branch 'master' of github.com:commercialhaskell/stack
      Merge branch 'master' of https://github.com/judah/stack
      Fix typo in tryIO
      Remove no longer needed Distribution.Version.Extra
      Merge pull request #3265 from commercialhaskell/remove-dist-version-extra
      No more hs-boot files
      Fix default subdirs value
      Merge pull request #3271 from feuerbach/master
      Merge pull request #3266 from commercialhaskell/no-hs-boot
      Merge pull request #3120 from alexeyzab/3006-speed-up-store-instances
      Support archives as a package location
      Merge pull request #3274 from commercialhaskell/archive-location
      Allow specifying cabal file by revision number
      --git-branch
      Error out when package.json files conflict
      Merge branch 'master' into skip-component
      Merge pull request #3148 from martin-kolinek/skip-component
      Fix relative custom snapshot location parsing
      Merge pull request #3276 from commercialhaskell/upgrade-by-branch
      Comment out some non-compiling test code
      Introduce the Subdirs type
      Merge pull request #3278 from commercialhaskell/3263-parent-custom
      Fix style issue
      Merge branch 'revision-by-number'
      Merge branch 'master' of github.com:commercialhaskell/stack
      Better definition of errorString
      Drop a few dependencies
      Switch to unliftio package
      Move StackT into Stack.Prelude
      Fully loaded Stack.Prelude
      Add mintty
      More unused imports c/o GHC 7.10.3
      Stylish
      Add missing empty import
      Replace Env with Runner
      Merge remote-tracking branch 'origin/master' into stack-prelude
      Merge pull request #3279 from commercialhaskell/stack-prelude
      Merge remote-tracking branch 'origin/master' into env-to-runner
      Perform path check on stack upgrade #3232 (#3234)
      Merge pull request #3280 from commercialhaskell/env-to-runner
      No more StackMiniM
      Remove the StackM type synonym (fixes #1297)
      Move from StackT to RIO
      Travis: build store by itself due to high memory usage
      Merge pull request #3281 from commercialhaskell/1297-concrete-monad
      More informative typo corrections (handle revisions)
      Track cabal hashes with and without CRs
      Allow properly loading custom snapshots in scripts #3218
      Merge pull request #3287 from commercialhaskell/3218-custom-snapshots-scripts
      Merge pull request #3293 from filippovitale/patch-1
      Merge pull request #3294 from felixonmars/patch-3
      Merge pull request #3301 from gliptak/patch-2
      Stack.StaticBytes
      Store non-base-16 values internally
      Merge pull request #3302 from commercialhaskell/static-bytes
      Remove unneeded PackageInstallInfo class
      Switch to RIO in a few places
      Remove unneeded runRIO
      Fix resolver override settings
      Add a new line
      Minor simplifications
      Merge pull request #3305 from commercialhaskell/fixes-and-cleanups
      Merge remote-tracking branch 'origin/stable'
      Delete invalid snapshot files #3319
      Promote packages to local database by ghc-options #849
      Simplify GhcOptions, fix warning
      Merge pull request #3326 from commercialhaskell/3319-delete-invalid-snapshot-files
      Merge pull request #3327 from commercialhaskell/849-unify-flags-ghc-options
      Introduces $locals et al ghc-options keys
      Merge pull request #3333 from commercialhaskell/3329-locals-options
      Merge branch 'master' into ghc-color-output
      Create color-stripped version of logs
      Merge pull request #3337 from commercialhaskell/kadoban-ghc-color-output
      Proper process output for empty args
      Don't pass empty arg for color flag GHC < 8.2
      Merge pull request #3339 from commercialhaskell/fix-script-base
      Modify flag parser to allow sequential dashes #3345
      Merge pull request #3349 from commercialhaskell/3345-fix-flag-parser
      Remove support for old precompiled cache format
      Include full package location info in precompiled cache key #3346
      Merge pull request #3347 from commercialhaskell/3346-precompiled-cache-key
      Better typing around SnapshotHash
      Switch from Local/Upstream to Files/Index
      Merge pull request #3351 from commercialhaskell/remove-psupstream
      Use multilines in Travis for easier future modification
      More resilient PVP bounds in Travis for cabal
      Switch integration tests to new custom snapshot syntax
      Remove invalid GHC options in test (fixes #3358)
      Upgrade to Cabal 2.0
      Proper grabbing of all build info
      Proper build tool loading from Cabal files
      Remove redundant (and now incorrect) packageToolDependencies function
      Move getDefaultPackageConfig to where it is used
      Make tests and benchmarks run again
      Fiddle with the buildable field correctly
      Merge pull request #3288 from commercialhaskell/cabal-2
      Merge pull request #3375 from alexeyzab/3070-improve-stack-upgrade-docs
      Merge pull request #3386 from aktowns/stable
      Switch to CallStack logging #3373
      Use CallStack for Stack.PrettyPrint #3373
      Remove some unneeded TemplateHaskell #3373
      hlint cleanups
      Include failing test case for #3390
      Unbuildable tests are not built (fixes #3390)
      Remove the "implicitly added" messages (closes #3398)
      Merge pull request #3403 from commercialhaskell/3398-remove-implicitly-adding
      Support for Cabal 2.0 sub and foreign libraries
      allBuildInfo' as workaround for haskell/cabal#4763
      hlint fixes
      Merge pull request #3430 from commercialhaskell/sub-foreign-libraries
      Failing test case for #3431
      Do correct path checking in precompiled cache.
      Merge pull request #3494 from commercialhaskell/3431-fix-precompiled-cache-checks
      Failing test case for #3397
      Allow solver to work with ghc- resolver (fixes #3397)
      Merge pull request #3498 from commercialhaskell/3397-ghc-solver
      Set the EnvOverride properly when using the solver
      Make tests more robust locally
      Add failing test case for #2781
      Force reconfigure when deps rebuild #2781
      Add convenience hlint.sh script
      Merge pull request #3503 from commercialhaskell/2781-shadow-bug
      Check for deps on exe-only packages #2195
      Merge pull request #3505 from commercialhaskell/2195-dep-on-exe
      Merge pull request #3502 from denibertovic/deni/3396-package-indices
      Failing test case for #3533
      Ensure solver does not put local packages in extra-deps #3533
      Warn about 00-index vs 01-index #3520
      Better errors for 00-index, and ignore-revision-mismatch #3520
      Merge pull request #3541 from commercialhaskell/3520-revision-matching
      Cache snapshot def parsing
      Merge pull request #3580 from commercialhaskell/cache-snapshot-def
      Ensure cabal file warnings display once (fixes #3591)
      Upgrade to hpack 0.20.0 (fixes #3383)
      Merge pull request #3592 from commercialhaskell/3591-cabal-warnings-once
      Merge pull request #3579 from commercialhaskell/3383-detect-hpack-cabal-changes
      Only tweak cabal file as necessary
      Add warnings to docs/release notes about pvp-bounds #3550
      Merge pull request #3595 from commercialhaskell/pvp-bounds-docs
      Automatically run autoreconf -i when needed #3534
      Don't apply $locals to extra-deps #3574
      Remove a false assertion
      SHA256 support for GHC setup info
      Add options: standlone for Windows #3605
      Merge pull request #3597 from commercialhaskell/sha256-ghc-info
      Merge branch 'master' into 3483-file-watch-components
      Merge branch 'master' into 3483-file-watch-components
      Strip trailing CR for file list (#3606)
      Merge pull request #3602 from commercialhaskell/config-yaml-extra-paths
      Merge branch 'master' into apply-specific-ghc-options-after-general-3573
      Update the travis-complex example
      Merge pull request #3576 from commercialhaskell/apply-specific-ghc-options-after-general-3573
      Merge branch 'master' into drop-ghcrts-env-var
      Ensure proper path propagation for stack init #3607
      Do less EnvOverride explicit passing #3607
      Merge pull request #3608 from commercialhaskell/travis-complex-update
      Merge pull request #3445 from commercialhaskell/drop-ghcrts-env-var
      Merge pull request #3609 from commercialhaskell/3607-stack-init-solver
      Merge pull request #3565 from tswelsh/3483-file-watch-components
      Add AppVeyor docs
      Code simplification and a bit more strictness
      Merge pull request #3611 from commercialhaskell/add-appveyor-docs
      Merge pull request #3612 from commercialhaskell/minor-code-cleanup
      Don't parse cabal files twice
      Refactoring around cabal file parsing
      Style cleanup
      Better exception on mismatch
      Don't track hpack run cache separately
      Redisable test on OS X due to Unicode normalization
      Merge pull request #3615 from commercialhaskell/parse-cabal-files-once
      Support unliftio-0.2.0.0 #3625
      Fix non-buildable bug in Cabal <= 1.22
      Merge pull request #3632 from commercialhaskell/cabal-non-buildable-bug
      Better cabal file checking
      Merge pull request #3640 from commercialhaskell/check-caret-operator
      More compat with buggy Cabal buildable deps #3631
      Support .tar archives #3647
      Share file read for archives
      Merge pull request #3654 from commercialhaskell/3631-build-http2
      Merge pull request #3655 from commercialhaskell/3647-uncompressed-tarballs

Neil Mitchell (4):
      #3362, ensure we always generate hoogle documentation when running Haddock
      #3362, update the changelog
      #3572, update advice on what a good default for package-indices
      Mention package-indices change in the changelog

Oleg Grenrus (2):
      GHC 8.2.1
      Don't drop -Werror on GHC-8.2.1

OvermindDL1 (1):
      Fix `get-stack.sh` to support RedHat Enterprise

Paolo G. Giarrusso (5):
      Use OpenBSD release as part of bindist name
      Codestyle cleanup: Name OS uniformly
      sysRelease: handle exceptions locally
      Fix compilation for Windows
      Merge pull request #3184 from commercialhaskell/check-openbsd-release

Rafe (1):
      Revert "Clean up --only-dependencies logic in ConstructPlan"

Reuben D'Netto (1):
      Prefer more recent version of libtinfo when selecting GHC build

Roman Cheplyaka (1):
      travis-complex.yml: run tests when building with cabal

Samuli Thomasson (1):
      Fix parallel invocation of `stack --docker` (#3400)

Schlueter (1):
      Link directly to shell autocompletion on doc site

Scott Fleischman (1):
      Add hpack configuration option.

Shea Levy (1):
      When using Nix, depend on gcc.

Simon Jakobi (1):
      init: Load snapshots on demand during resolver selection

Tom Sydney Kerckhove (5):
      Print retry information if stack needs to retry network requests
      made 'fails' more specificy
      Use Stack.PrettyPrint to print the warning instead
      Turned the exception argument into a wildcard, to get rid of a warning
      Fixed the tests accordingly

Walter Franzini (1):
      Fix STACK_IN_NIX_SHELL environment variable name

alexey zabelin (3):
      Start implementing #3006
      Use StaticSize 64 ByteString for pdSHA256
      Update ChangeLog.md

d-dorazio (1):
      add --ghc-options to stack script

mrkkrp (1):
      Use ‘text-metrics-0.3.0’

tswelsh (5):
      Log passed/failed when tests complete
      Update changelog
      Don't watch files for non-library components that are not being built
      Update changelog
      Make addUnlistedToBuildCache use the same logic for getting files as loadLocalPackage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants