Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add architecture to hash sandbox dir #2790

Closed
wants to merge 2 commits into from

Conversation

microtorus
Copy link

This patch allows for 32-bit and 64-bit concurrent builds.

This ensures that dependencies built for different architectures will not get mixed into the same dist-sandbox directory thus allowing for x86 and x86_64 builds in the same working space and even concurrently.

This patch allows for 32-bit and 64-bit concurrent builds.
@23Skidoo
Copy link
Member

Instead of just $arch, please use $arch-$os-$compiler, like we do elsewhere. Instead of just hashing it, please change the directory to dist/dist-$HASH/$arch-$os-$compiler (aside: we should probably be using a platform-specific directory separator here instead of a slash).

@BardurArantsson
Copy link
Collaborator

@ezyang Is this relevant after your changes to "pkgid", etc?

If yes, then why aren't we merging this?

@ezyang
Copy link
Contributor

ezyang commented Jan 29, 2016

This looks orthogonal, because it is related to sandbox directory selection which is not based off of a computed component ID. Which mean it should be relevant.

@23Skidoo
Copy link
Member

why aren't we merging this?

I guess because GitHub doesn't send notifications when the submitter updates the PR by pushing additional commits. I'll postpone this until after 1.24 is branched because I think there's some potential for breakage.

@BardurArantsson
Copy link
Collaborator

Ugh. Another "process" thing forced upon us by GitHub :(

(Good work, btw, getting a release together!)

@23Skidoo 23Skidoo mentioned this pull request Feb 16, 2016
@23Skidoo 23Skidoo added this to the Cabal 1.26 milestone May 7, 2016
@23Skidoo 23Skidoo removed the post-1.24 label May 7, 2016
@ezyang ezyang modified the milestones: Obsoleted by nix-local-build, Cabal 2.0 Sep 6, 2016
@phadej
Copy link
Collaborator

phadej commented Jan 22, 2020

Sandbox is deprecated.

@phadej phadej closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants