New freeze command #3503
Merged
New freeze command #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No detail from the appveyor build. No report from travis? |
|
@dcoutts appveyor seems to fail recently for no obvious reason; no travis report is odd though |
| ( normal ) | ||
|
|
||
| #if !MIN_VERSION_base(4,8,0) | ||
| import Data.Monoid (Monoid(mempty)) |
There was a problem hiding this comment.
If this is the only reason for CPP, we can avoid this by referring to mempty at least once qualified...
|
Passes on both AppVeyor and Travis now. |
| @@ -235,6 +235,7 @@ rebuildInstallPlan :: Verbosity | |||
| -> FilePath -> DistDirLayout -> CabalDirLayout | |||
| -> ProjectConfig | |||
| -> IO ( ElaboratedInstallPlan | |||
| , ElaboratedInstallPlan | |||
There was a problem hiding this comment.
It'd be nice to add some comments explaining the return type.
|
LGTM modulo comments. |
|
So I think I'll squash the fixup patches and merge. I've noted some related TODOs in #3104. |
|
Great, let's merge. |
It takes a solver plan, makes an "elaborated plan" with nix style hashes but still of mostly source package and then does an improvement phase to make a plan with pre-existing packages from the store. Previously it only returned the improved plan, but for some things it's also useful to see the original elaborated plan with the source packages. In partciular it will be useful for plan.json status output. It will also be needed for the freeze command to be able to get at the flag choices, since this info is not preserved in installed packages.
There are various related properties here like packages that are going to be built locally inplace rather than added to the store, but sometimes we need to know if a package was originally specified by the cabal.project file (explicitly or implicitly).
Code to write it and to pick it up by default when reading the cabal.project file.
This is ok, but not perfect since freezing is now more tricky with setup deps. See haskell#3502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new-freeze command, the freeze command to go along with the other new project-based commands.
See also #3502