-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One-component configure #3644
One-component configure #3644
Conversation
Signed-off-by: Edward Z. Yang <[email protected]>
3f3fc09
to
c5db313
Compare
As it's in ghc-proposals, we have to wait what it says before merging this? |
Well, Cabal is not within the ghc-proposals mandate, and even if it were, there is currently no timeline the process becomes "official". So yes I would like to get commentary, but I also think we can informally decide when it's good enough to go in. |
As we added it there, let's wait ~2 weeks (the usual discussion time on proposals in e.g. libraries), otherwise it will look like "look we decided to do this way, now it's already done". I like the idea of proposal, but as you posted it there, I'd give people opportunity to comment on it. Sorry that it will delay this PR. |
Two weeks is fine. I am well used to the rebased branches on top of rebased branches workflow for extended periods of time ;) |
83814b5
to
f72be75
Compare
Described in: ghc-proposals/ghc-proposals#4 ./Setup configure now takes an argument to specify a specific component name that should solely be configured. Most of the gyrations in Configure are all about making it so that we can feed in internal dependencies via --dependency. I dropped the package name match sanity check to handle convenience library package name munging. I also had to make register/copy unconditionally install internal libraries; otherwise you can't refer to them from later builds. Also a miscellaneous refactor: convenience libraries are printed with a "header" stanza now (not really a stanza header). Signed-off-by: Edward Z. Yang <[email protected]>
f72be75
to
91da0be
Compare
Since this commit is rolled up in #3662 I'm going to close this; review that PR instead. |
Described in: ghc-proposals/ghc-proposals#4
./Setup configure now takes an argument to specify a specific
component name that should solely be configured.
Most of the gyrations in Configure are all about making it so that
we can feed in internal dependencies via --dependency. I dropped
the package name match sanity check to handle convenience library
package name munging. I also had to make register/copy unconditionally
install internal libraries; otherwise you can't refer to them
from later builds.
Also a miscellaneous refactor: convenience libraries are printed with a
"header" stanza now (not really a stanza header).