Mark template-haskell non-upgradable (again)
#4185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65e9b88 made template-haskell non-upgradable 65ae95c made it upgradable again ...and this commit makes it non-upgradable again While there may be a few cases when `template-haskell` can be reinstalled, it's generally not advisable, and causes more harm than the benefit in the few cases where we'd gain install-plan flexibility (e.g. when only template-haskell's API is needed for compile, but no actual TH evaluation takes place). Closes haskell#4098
|
OK. Do we want this backported to 1.24? |
|
@23Skidoo probably; there is a slight risk that it may outlaw working install-plans (e.g. those which don't actually evaluate TH code using the reinstalled template-haskell lib), but it would reduce the risk of users being confused about the weird error messages they get when this causes errors due to GHC being confused. So I'd suggest to backport this to the next 1.24 point rls of cabal-install |
|
Merged, thanks! |
|
Also cherry-picked into 1.24 (141effc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
65e9b88 made template-haskell non-upgradable
65ae95c made it upgradable again
...and this commit makes it non-upgradable again
While there may be a few cases when
template-haskellcan bereinstalled, it's generally not advisable, and causes more harm than the
benefit in the few cases where we'd gain install-plan
flexibility (e.g. when only template-haskell's API is needed for
compile, but no actual TH evaluation takes place).
Closes #4098