Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try update-alternatives ld #4441

Merged
merged 1 commit into from
Jul 5, 2017
Merged

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Apr 7, 2017

No description provided.

@mention-bot
Copy link

@phadej, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezyang, @23Skidoo and @tibbe to be potential reviewers.

@phadej
Copy link
Collaborator Author

phadej commented Apr 7, 2017

Anyone have idea what's happening

/usr/bin/ld: --hash-size=31: unknown option

?

@alexbiehl
Copy link
Member

alexbiehl commented Apr 7, 2017

GHC checks ld and passes --hash-size=32 to it if it has GNU ld in its version info.
(Cf. ghc/ghc@71a194d#diff-183a20ee6313d2c3600ef96e732176a3R660). gold is not passed any additional options.

I have no idea what that means to this case though.

@phadej
Copy link
Collaborator Author

phadej commented Apr 7, 2017

@alexbiehl, ok so it's expected that gold doesn't work with GHC pre 7.8.x. Thanks

@phadej
Copy link
Collaborator Author

phadej commented Apr 13, 2017

It seems that the test isn't that much faster with gold, @nh2 do you have any ideas why so? Is it related to #4439 ?

@ezyang
Copy link
Contributor

ezyang commented Apr 13, 2017

We should verify that gold is actually being used for the tests. But perhaps the issue is that gold shines when linking large projects, and the test suite is basically always doing very small things.

@23Skidoo
Copy link
Member

23Skidoo commented Apr 28, 2017

-pgml shouldn't play a role here, since we don't use it in the script.

@ezyang ezyang mentioned this pull request May 7, 2017
@23Skidoo
Copy link
Member

23Skidoo commented Jul 5, 2017

I think I'll merge this, because it's a small change, but feel free to revert if you disagree.

@23Skidoo 23Skidoo merged commit 228d1b9 into haskell:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants