Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign Library RTS Selection #5431

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

TravisWhitaker
Copy link
Collaborator

Fresh PR for #5118

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

@23Skidoo 23Skidoo added this to the 2.4 milestone Jul 31, 2018
@sergv
Copy link
Collaborator

sergv commented Aug 24, 2018

@23Skidoo Could we merge this, please? The prerequisite #5118 was closed stating that something's merged, presumably this PR, but it looks like it isn't.

@23Skidoo
Copy link
Member

@sergv Thanks for the reminder, for some reason I believed that this was already merged.

@23Skidoo 23Skidoo merged commit 2f8c435 into haskell:master Aug 29, 2018
23Skidoo added a commit that referenced this pull request Aug 29, 2018
@23Skidoo
Copy link
Member

Also cherry-picked into 2.4.

@@ -1979,9 +1976,6 @@ checkForeignLibSupported comp platform flib = go (compilerFlavor comp)

goGhcLinux :: ForeignLibType -> Maybe String
goGhcLinux ForeignLibNativeShared
| standalone = unsupported [
Copy link
Collaborator

@phadej phadej Oct 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is removed. I get a lot of

/usr/bin/x86_64-linux-gnu-ld.gold: error: /opt/ghc/8.6.1/lib/ghc-8.6.1/base-4.12.0.0/libHSbase-4.12.0.0.a(Lex.o): requires unsupported dynamic reloc 11; recompile with -fPIC

... if I try to build options: standalone library on Linux

See also: #4827

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This build type is supported in general, just not by the GHC you have installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants