Set abiDepends field in IPI to [] #5478
Conversation
| Nothing -> error $ | ||
| "generalInstalledPackageInfo: missing IPI for " ++ display uid | ||
| Just ipi -> IPI.abiHash ipi | ||
| -- Commented due to #5465 |
There was a problem hiding this comment.
Just delete this bit, Git does the job of storing history better.
|
@23Skidoo , I rebased on master and now I have troubles with building the project after the version bump. I've noticed bunch of |
|
Thanks! Rebased. |
|
@ezyang, can you please approve this fix? |
|
@23Skidoo note that we should backport this one to the next lib:Cabal-2.2 point rls, if we ever do one (in order to help cover some custom-setup situations; and to have it ready in case we get a GHC 8.4.4) |
|
As long as this has been tested against versions of GHC which respected the field, I'm OK with it. |
Cabal/ChangeLog.md
Outdated
| @@ -80,6 +80,8 @@ | |||
| * Added a parameter to | |||
| `Distribution.Backpack.ConfiguredComponent.toConfiguredComponent` in order to fix | |||
| [#5409](https://github.com/haskell/cabal/issues/5409). | |||
| * Partially silence `api-depends` warnings | |||
|
@ezyang I've dogfooded this a bit w/ GHC 8.2 and GHC 8.4, and I haven't noticed any issues yet. What kind of problems would you expect? Wouldn't omitting the |
|
I don't expect problems, but if there was a problem, GHC 8.2 is where I would expect it to manifest. So if it's been tested, all good by me. |
|
alright then; then I'll merge this and thus extend the testing user-base to our early adopters... :-) |
|
Cherry-picked to |
Resolves #5465
[ci skip]is used to avoid triggering the build bots.I have tried to
new-buildone personal package, and the output was without anyabi-dependsrelated warnings. However, when I was usingnew-installon the same package, the warnings were still printed out. So this is not the complete fix of the task, but I don't know what can be done about that.