Hack around #5119 by disabling the warning. #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue haskell#5119 is tracking spurious generation of these warnings. There are a lot of them! We can't release with so many false positives, so just squelch the warning outright. This is a hack and this commit should be reverted if we get a proper fix that can be backported to the 2.4 branch.
|
Please note that this is targetting 2.4 only and not master. When/if this gets merged, it'll mean #5119 is no longer critical to fix before the release, though we should definitely try to get it done before 3.0. cc @Ericson2314. |
|
OK, let's apply a workaround in 2.4 and later try to fix the issue properly in |
Ericson2314
approved these changes
Aug 14, 2018
|
OK, the only failure is because of a timeout on OSX. Let's do this. |
23Skidoo
pushed a commit
to 23Skidoo/cabal
that referenced
this pull request
Jun 25, 2019
Issue haskell#5119 is tracking spurious generation of these warnings. There are a lot of them! We can't release with so many false positives, so just squelch the warning outright. This is a hack and this commit should be reverted if we get a proper fix that can be backported to the 2.4 branch. (cherry picked from commit e8ba731)
23Skidoo
pushed a commit
to 23Skidoo/cabal
that referenced
this pull request
Jun 25, 2019
Issue haskell#5119 is tracking spurious generation of these warnings. There are a lot of them! We can't release with so many false positives, so just squelch the warning outright. This is a hack and this commit should be reverted if we get a proper fix that can be backported to the 2.4 branch. (cherry picked from commit e8ba731)
DanielG
pushed a commit
to DanielG/cabal
that referenced
this pull request
Aug 17, 2019
Issue haskell#5119 is tracking spurious generation of these warnings. There are a lot of them! We can't release with so many false positives, so just squelch the warning outright. This is a hack and this commit should be reverted if we get a proper fix that can be backported to the 2.4 branch. (cherry picked from commit e8ba731)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5119 is tracking spurious generation of these warnings. There
are a lot of them! We can't release with so many false positives, so
just squelch the warning outright.
This is a hack and this commit should be reverted if we get a proper
fix that can be backported to the 2.4 branch.
Please include the following checklist in your PR:
[ci skip]is used to avoid triggering the build bots.Please also shortly describe how you tested your change. Bonus points for added tests!