Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a bunch of previously deprecated stuff in preparation for the 3.0 release. #6022

Merged
merged 3 commits into from
May 6, 2019

Conversation

23Skidoo
Copy link
Member

@23Skidoo 23Skidoo commented Apr 30, 2019


Please include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Any changes that could be relevant to users have been recorded in the changelog.
  • The documentation has been updated, if necessary.
  • If the change is docs-only, [ci skip] is used to avoid triggering the build bots.

Please also shortly describe how you tested your change. Bonus points for added tests!

@23Skidoo 23Skidoo requested a review from phadej April 30, 2019 20:48
@23Skidoo 23Skidoo force-pushed the cabal-3.0-remove-deprecated branch from 4a74929 to 892e3d2 Compare April 30, 2019 22:05
@23Skidoo
Copy link
Member Author

23Skidoo commented May 2, 2019

Hmm, some config roundtrip tests are failing. Not sure why yet...

@23Skidoo 23Skidoo force-pushed the cabal-3.0-remove-deprecated branch from 892e3d2 to c7fe8de Compare May 3, 2019 15:44
@23Skidoo
Copy link
Member Author

23Skidoo commented May 3, 2019

Figured out what the problem was thanks to tree-diff: deprecated command-line options that I removed (--enable-library-coverage and --enable-executable-profiling). Rolled back that change for now.

@23Skidoo 23Skidoo force-pushed the cabal-3.0-remove-deprecated branch from c7fe8de to 5bfbf09 Compare May 3, 2019 16:16
@23Skidoo 23Skidoo force-pushed the cabal-3.0-remove-deprecated branch from 5bfbf09 to e3bb1cf Compare May 3, 2019 17:23
@23Skidoo 23Skidoo merged commit 33c271e into haskell:master May 6, 2019
@23Skidoo 23Skidoo deleted the cabal-3.0-remove-deprecated branch May 6, 2019 02:45
@bgamari
Copy link
Contributor

bgamari commented Jun 5, 2019

This has broken ghc-cabal. Please consider what effect a patch will have on GHC before merging things like this so late in the release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants