Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept any pkg-config --modversion output #6541

Merged
merged 1 commit into from
Feb 14, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Feb 14, 2020

This results e.g. in

cabal: The pkg-config package 'blas' version ==0.3 || >0.3 is required but the
version installed on the system is version 0.2.20+ds

output instead of failing to parse 0.2.20+ds as a PkgconfigVersion.
We don't need to parse the pkg-config --modversion output
as strictly as the versions in .cabal file.
I.e. at all, as PkgconfigVersion comparison works somehow
on any possible version strings.

cc @amigalemming if you want to try this out. I'll backport it to 3.2 branch.
You won't be able to write + in .cabal file, but at least Cabal will accept whatever pkg-config --modversion gives it.

This results e.g. in

    cabal: The pkg-config package 'blas' version ==0.3 || >0.3 is required but the
    version installed on the system is version 0.2.20+ds

output instead of failing to parse 0.2.20+ds as a PkgconfigVersion.
We don't need to parse the `pkg-config --modversion` output
as strictly as the versions in `.cabal` file.
I.e. at all, as `PkgconfigVersion` comparison works somehow
on any possible version strings.
@phadej phadej added this to the 3.2.0.0 milestone Feb 14, 2020
@phadej phadej merged commit 3e05a15 into haskell:master Feb 14, 2020
@phadej phadej deleted the accept-any-modversion branch February 14, 2020 14:34
@phadej phadej mentioned this pull request Feb 14, 2020
@phadej
Copy link
Collaborator Author

phadej commented Feb 14, 2020

Backported in #6542

@phadej phadej mentioned this pull request Jul 10, 2020
@andreasabel andreasabel added the re: pkg-config Concerning pkg-config and pkgconfig-depends constraints label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
re: pkg-config Concerning pkg-config and pkgconfig-depends constraints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants