Accept any pkg-config --modversion output #6541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This results e.g. in
output instead of failing to parse 0.2.20+ds as a PkgconfigVersion.
We don't need to parse the
pkg-config --modversion
outputas strictly as the versions in
.cabal
file.I.e. at all, as
PkgconfigVersion
comparison works somehowon any possible version strings.
cc @amigalemming if you want to try this out. I'll backport it to 3.2 branch.
You won't be able to write
+
in.cabal
file, but at leastCabal
will accept whateverpkg-config --modversion
gives it.