Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Described Mixin #6800

Merged
merged 1 commit into from
May 14, 2020
Merged

Described Mixin #6800

merged 1 commit into from
May 14, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 14, 2020

Related to #6281

Screenshot from 2020-05-14 20-29-27

(black dots are where space is required).

@phadej phadej merged commit 9c148f7 into haskell:master May 14, 2020
@phadej phadej deleted the mixin-described branch May 14, 2020 19:09
@phadej
Copy link
Collaborator Author

phadej commented May 14, 2020

I think

mixins: pkg(Module)requires(Module2)

is accepted by the parser but not precisely Described. The whitespace is tricky when we have infix keywords and empty productions. E.g.

mixins: pkg requires(Module2 as Module3)
mixins: pkg requires hiding{Module4}

@phadej phadej added this to the 3.4.0.0-rc1 milestone Jul 10, 2020
@phadej phadej mentioned this pull request Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant