Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and fix for #6961 #6964

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Add tests and fix for #6961 #6964

merged 2 commits into from
Jul 15, 2020

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 14, 2020

No description provided.

@phadej phadej changed the title Add tests for #6961 Add tests and fix for #6961 Jul 14, 2020
@phadej phadej requested a review from grayjay July 14, 2020 20:35
Copy link
Member

@fgaz fgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't some of the tests overlapping with cabal-testsuite/PackageTests/MultipleLibraries?

@phadej
Copy link
Collaborator Author

phadej commented Jul 15, 2020

@fgaz, most likely they do.

In fact I'd preferred to just extend unit-tests with these scenarios, but it seems that framework doesn't allow asking for test-suites stanzas. I might be wrong.

@phadej phadej merged commit 66e96d9 into haskell:master Jul 15, 2020
@phadej phadej deleted the issue-6961-tests branch July 15, 2020 11:48
@phadej phadej added this to the 3.4.0.0 milestone Jul 15, 2020
@phadej
Copy link
Collaborator Author

phadej commented Jul 15, 2020

Backported in #6967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants