Generalise -- for v2-test, v2-bench, and v2-run
#7454
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR is a draft, and the code as of now is only a POC of what I proposed in #6198 (comment). |
ptkato
commented
Jun 22, 2021
Comment on lines
+188
to
+191
| if not (null args1) | ||
| && not (null args0) | ||
| && elem (take 1 args0) | ||
| (map return ["run", "v2-run", "new-run", "test", "v2-test", "new-test", "bench", "v2-bench", "new-bench"]) |
There was a problem hiding this comment.
I don't like this if, it's too ad hoc-y, however it seems that the actual build phase calls on this part of the code again (I'm actually not sure, see here). So if I don't handpick the command, it starts complaining i.e. unrecognized 'act-as-setup' option '--ghc', and fails to build.
mergify
bot
added
the
merge delay passed
ulysses4ever
removed
the
merge delay passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to generalise the arguments that are passed to the executables called through
v2-runfor all the commands that could make use of such feature, as of nowv2-test,v2-bench, andv2-runitself. The motivation for this "change" is that people often try to use--and it doesn't work;When the arguments reach the command function, they're all mangled together in a single
[String]. While that usually works fine forv2-run, due to how it is structured (the command itself takes only one argument, that is the executable name), it won't work for the other commands, this PR will level--for all the afore mentioned commands.This PR fixes #6198. It will also close, possibly, #5416.
Please include the following checklist in your PR: