Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Cabal 3.6.1.0 entry changelog #7600

Merged
merged 5 commits into from
Aug 31, 2021
Merged

add Cabal 3.6.1.0 entry changelog #7600

merged 5 commits into from
Aug 31, 2021

Conversation

emilypi
Copy link
Member

@emilypi emilypi commented Aug 30, 2021


Please include the following checklist in your PR:

Please also shortly describe how you tested your change. Bonus points for added tests!

@emilypi
Copy link
Member Author

emilypi commented Aug 30, 2021

@Mergifyio backport 3.6

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2021

Command backport 3.6: pending

Waiting for the pull request to get merged

Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but is it really 4 changelog items form a couple dozen commits?

@Mikolaj
Copy link
Member

Mikolaj commented Aug 30, 2021

This is the list of commits that go in, right?

Cabal-v3.6.0.0...3.6

@emilypi
Copy link
Member Author

emilypi commented Aug 30, 2021

Looks about right @Mikolaj. Alot of them are docs changes.

@Mikolaj
Copy link
Member

Mikolaj commented Aug 30, 2021

#7561 doesn't have changelog, so that explains one case. Two other cases are the solver speedups: #7532 and #7516. And then a couple of docs tweaks where we don't expect changelogs. I think all are accounted for; we are fine.

@emilypi
Copy link
Member Author

emilypi commented Aug 30, 2021

Ah the prepositive one and the solver ones. Okay, thanks @Mikolaj

@Mikolaj Mikolaj merged commit 95a9241 into master Aug 31, 2021
@Mikolaj
Copy link
Member

Mikolaj commented Aug 31, 2021

I abused my privilege and merged with 1 review, given that these are only changelogs so little bugs are not lethal.

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2021

Command backport 3.6: success

Backports have been created

@emilypi emilypi deleted the cabal-3.6.1.0-changelog branch August 31, 2021 19:08
emilypi added a commit that referenced this pull request Aug 31, 2021
[ci skip] add Cabal 3.6.1.0 entry changelog (backport #7600)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants