Include extra-lib-dirs-static into PackageHash

[alexbiehl]

Continuing working on the matter and found we were missing the extra-libs-static in PackageHash.

---

Please include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
• The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!

[Mikolaj]

Given that there's no test and, I assume, the main PR will be tested, could you add a changelog and mention there the main PR and/or main issue?

[jneira]

We could add a test similar to the used one for check the fix for duplicate entries in package hash inputs: https://github.com/haskell/cabal/tree/master/cabal-testsuite/PackageTests/Regression/T6906

[Mikolaj]

@alexbiehl: CI should run fine once you rebase --- I fixed the failure.

[Mikolaj]

CI is green, we just need a minimal changelog file and test.

[Mikolaj]

@alexbiehl: may I help you in getting this PR to the finish line? :)

[alexbiehl]

@alexbiehl: may I help you in getting this PR to the finish line? :)

I am sorry I didn't get to this. Help would be very much appreciated.

[alexbiehl]

I also opened https://gitlab.haskell.org/ghc/ghc/-/issues/20759 upstream to track the GHC side of things.

[Mikolaj]

Given that this is a part of #6935, the changelog.d/pr-7794 could be

synopsis: Include extra-lib-dirs-static into PackageHash
packages: cabal-install
prs: #7794
issues: #6935

[Mikolaj]

We could add a test similar to the used one for check the fix for duplicate entries in package hash inputs: https://github.com/haskell/cabal/tree/master/cabal-testsuite/PackageTests/Regression/T6906

@alexbiehl: I think a copy-paste of this test would be an acceptably cheap way of testing this functionality. What do you think? Would you add that?

[Mikolaj]

@alexbiehl: ping?

[jneira]

Given that this is a part of #6935, the changelog.d/pr-7794 could be

synopsis: Include extra-lib-dirs-static into PackageHash
packages: cabal-install
prs: #7794
issues: #6935

hmm #6935 is a pr, not an issue, and afaics #6935 does not have a clear linked issue, so maybe we should remove issues: #6935 from the changelog?

[jneira]

@Mergifyio rebase master

[mergify]

rebase master

✅ Branch has been successfully rebased

[jneira]

the pr looks good but needs a changelog entry and a test, thanks

[emilypi]

Changelog entry + tests should be added - approved otherwise

[Mikolaj]

@mergify rebase

[mergify]

rebase

✅ Branch has been successfully rebased

[Mikolaj]

@alexbiehl: the PR is still good, CI passes! May we assist you in shipping it? Alternatively, would you like to post it for adoption?

[Mikolaj]

@alexbiehl: respectful ping?

[alexbiehl]

Hi! I am not sure how to test this TBH. Also this is a bug fix for something that is purely internal rn so I am not sure it needs an entry in the changelog.

[Mikolaj]

@alexbiehl: I hope we can meet in the middle. :D

We require changelogs for anything that differs from last published version, regardless of how internal the things are (so only a fix of a bug introduced in devel version would not require a changelog, if it refrained from modifying any extra things). However, if the test is hard to do and the change is internal, I think we can risk it (more than usual) without a dedicated test.

BTW, if you could also smuggle into the PR the changelog fixup @jneira mentions in #7794 (comment), that would be super-awesome.

[alexbiehl]

@Mikolaj I did add the changelog entry as suggested by @jneira

[jneira-stratio]

a test would be great, bur as you consider, thanks!

[Mikolaj]

@alexbiehl: feel free to add the trigger label: merge_me or merge_me+squash.

[Mikolaj]

@alexbiehl: thank you once again. BTW. we now merge via the mergify labels: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#github-pull-request-conventions, which prevents complicated merge histories such us the one you just created and give interested people 2 more days to look at the final code before it's (rebased and) merged.