-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cabal: Reexport all of Cabal-syntax #8064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Minor? caveat, reexported-modules, like other backpack related features are not well supported by Not sure if someone would want use stack repl or load the project in hls using stack, though. |
Reviewing other prs in hls about it seems there was a fix in hls itself about: haskell/haskell-language-server#2468 and maybe it would work. I had to test it to confirm. But still |
We are testing Cabal the lib for several ghcs < 7.10.3 and the tests did pass (https://github.com/haskell/cabal/runs/5687246403?check_suite_focus=true). And afaiu we are using cabal head at runtime for tests 🤔 |
Ok, at build time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, reexportsi s the cleaner way and i hope the stack repl
issue will not impact most cabal developer, thanks!
As we are gonna drop support for build Cabal < 8.0 and this only restricts it to < 7.10.3 i think it would be fine.
But the changelog should note it (and it should be noted in the release in a more relevant way if the next version does not drop support for ghc < 8.0, but it would be in another pr)
We did drop the support finally, right? #8079 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mikolaj thanks for the reminder, yeah, this is not reducing support over master anymore
To preserve compatibility for downstream users Cabal will reexport all of Cabal-syntax for the time being. In the future we may deprecate these reexports. This requires that we bump the cabal-version of Cabal.cabal to 1.22 and drops support for GHC < 7.10. Closes haskell#7974.
To preserve compatibility for downstream users Cabal will reexport all
of Cabal-syntax for the time being. In the future we may deprecate these
reexports.
This requires that we bump the cabal-version of Cabal.cabal to 1.22 and
drops support for GHC < 7.10.
Closes #7974.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!