Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GHC2024 (fixes #9736) #9791

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Support GHC2024 (fixes #9736) #9791

merged 1 commit into from
Mar 13, 2024

Conversation

adamgundry
Copy link
Member

This adds support for the GHC2024 language edition, which will be introduced with GHC 9.10. I've grepped for GHC2021 and copy-pasted; I'm not sure what QA notes or additional tests are needed (if any).

Mikolaj
Mikolaj approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@Mikolaj Mikolaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine without further additions as soon as the hashes are updated, as in #9502 and #8854

Thank you!

@adamgundry adamgundry force-pushed the wip/ghc2024 branch 2 times, most recently from c9c138a to 48e8478 Compare March 10, 2024 15:28
@adamgundry
Copy link
Member Author

I've experimentally determined the correct values of the hashes and doc/buildinfo-fields-reference.rst, though I don't really understand what those tests are testing. Presumably this is good to go though.

@adamgundry adamgundry added the merge me Tell Mergify Bot to merge label Mar 11, 2024
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Mar 13, 2024
@mergify mergify bot merged commit aaf16c4 into master Mar 13, 2024
58 checks passed
@mergify mergify bot deleted the wip/ghc2024 branch March 13, 2024 19:34
@ffaf1
Copy link
Collaborator

ffaf1 commented Apr 10, 2024

@mergify backport 3.12

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024 •
edited
Loading

backport 3.12

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 10, 2024
Merged
5 tasks
mergify bot added a commit that referenced this pull request Apr 10, 2024
@mergify
Merge pull request #9880 from haskell/mergify/bp/3.12/pr-9791
5ab8bf8 
Support GHC2024 (fixes #9736) (backport #9791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffaf1 ffaf1 ffaf1 left review comments

@geekosaur geekosaur geekosaur approved these changes

@Mikolaj Mikolaj Mikolaj approved these changes

Assignees
No one assigned
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamgundry @ffaf1 @Mikolaj @geekosaur @Kleidukos