Fix write-back rules for Set toList #602
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Thanks to GHC Trac ticket 16261, matching on `[]` in a rule LHS is pretty dicy. Generalize the write-back rules so we don't have to. * `NOINLINE` set-to-list conversions generally when fusion doesn't happen. Inlining these functions seems rather unlikely to be productive in general.
|
|
|
Haha, I just realized you were the one who reporter it 😅 |
|
Yes. I think it's likely that we should make this change anyway, to get write-back for appends, but the comment definitely needs to be fixed! |
|
@treeowl Assigning to you, and marking as a draft (not ready for review) to clarify the current status. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to GHC Trac ticket 16261, matching on
[]in a ruleLHS is pretty dicy. Generalize the write-back rules so we
don't have to.
NOINLINEset-to-list conversions generally when fusion doesn'thappen. Inlining these functions seems rather unlikely to be
productive in general.