Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve {Set,Map}.fromDistinct{Asc,Desc}List #950

Merged
merged 5 commits into from
Jun 24, 2023
Merged

Improve {Set,Map}.fromDistinct{Asc,Desc}List #950

merged 5 commits into from
Jun 24, 2023

Commits on May 30, 2023

  1. Benchmarks for {Set,Map}.fromDistinct{Asc,Desc}List

    @meooow25
    meooow25 committed May 30, 2023
    Configuration menu
    Copy the full SHA
    8d1d7de View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Improve {Set,Map}.fromDistinct{Asc,Desc}List 

    A faster and fusion-friendly implemention of the current strategy.

On GHC 9.2.5:
For Set this takes 56% less time when there is fusion and 30% when not.
For Map this takes 55% less time when there is fusion and 16% when not.
    @meooow25
    meooow25 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    80f6d2a View commit details
    Browse the repository at this point in the history

  2. Remove a now inaccurate claim in {Set,Map}.fromList

    @meooow25
    meooow25 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    22b883f View commit details
    Browse the repository at this point in the history

  3. Add a note explaining the implementation

    @meooow25
    meooow25 committed May 31, 2023
    Configuration menu
    Copy the full SHA
    60ca488 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Pull out linkTop and linkAll helpers as INLINABLE 

    And leave further optimization to GHC.
    @meooow25
    meooow25 committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    57d9315 View commit details
    Browse the repository at this point in the history