This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Use hole fit plugins to record holes instead of parsing error messages #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only works on 8.10+, so we would need to keep the parsing logic by CPPing the rest.
/cc @isovector I think this approach will provide a more robust way to get the local environment (
TcGblEnv
/TcLclEnv
) at a hole, instead of going throughLocalBindings
. Thoughts? The tactic logic could work entirely insideTcRn
.