This repository has been archived by the owner on Jan 2, 2021. It is now read-only.
Remove language extension completions. #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you port the tests too? |
|
I reviewed the existing tests in HLS. I think they provide similar coverage consistent with the tests I removed. Here are the tests I looked at |
pepeiborra
reviewed
Dec 11, 2020
pepeiborra
approved these changes
Dec 11, 2020
I'm not convinced that the tests in HLS provide the same coverage. In particular, they do not check that completions for specific language pragmas are generated. |
|
Um. I am sorry I don't understand. I did not remove any completion test. I just added a test to make sure we don't provide any pragma related completions from ghcide. Perhaps, you are referring to 'CodeActions'? If yes, I see the HLS tests are checking for specific pragmas, though they are not the same pragmas ghcide tests are covering. I assume, we would not need tests for all kinds of pragmas. Please could you clarify and I can address them. |
|
You are right, I didn't look closely enough at those tests and thought they were checking for completions, but they are not. Please fix the conflicts and this is ready to merge. |
gdevanla
force-pushed
the
remove-language-extension-completion-code-action
branch
from
f90bb6a
to
60d1a31
Compare
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 28, 2020
The ghcide merge includes haskell/ghcide#948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
pepeiborra
added a commit
to haskell/haskell-language-server
that referenced
this pull request
Dec 28, 2020
The ghcide merge includes haskell/ghcide#948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove language extension completions. * Remove code actions for language pragma extensions. * Remove unused defintions and imports * Remove test defintion use * Update comment describing why we return an empty list
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
The ghcide merge includes haskell/ghcide#948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove language extension completions. * Remove code actions for language pragma extensions. * Remove unused defintions and imports * Remove test defintion use * Update comment describing why we return an empty list
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
The ghcide merge includes haskell/ghcide#948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
* Remove language extension completions. * Remove code actions for language pragma extensions. * Remove unused defintions and imports * Remove test defintion use * Update comment describing why we return an empty list
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Dec 29, 2020
The ghcide merge includes haskell/ghcide#948 which removes the language extension code actions This makes the associated func-test fail, because the HLS plugin does not pass the test (only the ghcide code action did). This is because the HLS plugin uses commands, and the tests do not wait for the command edit to be applied. The fix is to change the HLS plugin to return a code action with edits and no commands
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes Completions and CodeActions from ghcide thus de-duping the same functionality they is currently available in HLS through the Pragmas plugin module here
Also addresses (haskell/haskell-language-server#380)