SessionLoader: batch load #6696
Annotations
15 warnings
|
The following actions uses node12 which is deprecated and will be forced to run on node16: rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, rwe/actions-hlint-setup@v1, rwe/actions-hlint-run@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Checking code:
exe/Wrapper.hs#L1
Warning in module Main: Use module export list ▫︎ Found: "module Main where" ▫︎ Perhaps: "module Main (\n module Main\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L462
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "[(Maybe FilePath)]" ▫︎ Perhaps: "[Maybe FilePath]"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L574
Warning in loadSessionWithOptions in module Development.IDE.Session: Use nubOrd ▫︎ Found: "nub" ▫︎ Perhaps: "nubOrd"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L610
Suggestion in loadSessionWithOptions in module Development.IDE.Session: Redundant $ ▫︎ Found: "foldr acc ([], all_targets', flags_map') $ cfps" ▫︎ Perhaps: "foldr acc ([], all_targets', flags_map') cfps"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L641
Warning in loadSessionWithOptions in module Development.IDE.Session: Use atomicModifyIORef'_ ▫︎ Found: "atomicModifyIORef' cradle_files (\\ xs -> (cfps <> xs, ()))" ▫︎ Perhaps: "atomicModifyIORef'_ cradle_files ((<>) cfps)"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L705
Warning in loadSessionWithOptions in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(fst)" ▫︎ Perhaps: "fst"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session.hs#L953
Suggestion in newComponentCache in module Development.IDE.Session: Redundant bracket ▫︎ Found: "(homeUnitId_ (componentDynFlags ci)) `OS.member` bad_units" ▫︎ Perhaps: "homeUnitId_ (componentDynFlags ci) `OS.member` bad_units"
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L1
Warning in module Development.IDE.Session.Diagnostics: Use module export list ▫︎ Found: "module Development.IDE.Session.Diagnostics where" ▫︎ Perhaps: "module Development.IDE.Session.Diagnostics (\n module Development.IDE.Session.Diagnostics\n ) where" ▫︎ Note: an explicit list is usually better
|
|
Checking code:
ghcide/session-loader/Development/IDE/Session/Diagnostics.hs#L87
Warning in parseMultiCradleErr in module Development.IDE.Session.Diagnostics: Use drop1 ▫︎ Found: "drop 1" ▫︎ Perhaps: "drop1"
|
|
Checking code:
ghcide/src/Development/IDE/Core/Compile.hs#L72
Warning in module Development.IDE.Core.Compile: Use fewer imports ▫︎ Found: "import Development.IDE.Core.FileStore ( resetInterfaceStore )\nimport Development.IDE.Core.FileStore ( shareFilePath )\n" ▫︎ Perhaps: "import Development.IDE.Core.FileStore\n ( resetInterfaceStore, shareFilePath )\n"
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Installing
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading