Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack install hls (upload package to hackage/stackage) #400

Closed
jeapostrophe opened this issue Sep 14, 2020 · 6 comments
Closed

Stack install hls (upload package to hackage/stackage) #400

jeapostrophe opened this issue Sep 14, 2020 · 6 comments
Labels
CI Continuous integration type: enhancement New feature or request

Comments

@jeapostrophe
Copy link

I'd like to be able to type stack install haskell-language-server in a stack package and have a version of all the tools I need for the version of GHC that package is using and put in a place where it will get found, if I change my LSP setup (in neovim) from cmd = { "haskell-language-server-wrapper", "--lsp" } to cmd = { "stack", "exec", "haskell-language-server-wrapper", "--lsp" }

@jneira jneira changed the title Stack install Stack install hls (upload package to hackage/stackage) Sep 15, 2020
@jneira
Copy link
Member

jneira commented Sep 15, 2020

That would be a nice feature, it needs the package in hackage and, optionally, in stackage. That, in turn, needs that hls uses ghcide from hackage instead as a submodule.

@jneira jneira added CI Continuous integration type: enhancement New feature or request labels Sep 15, 2020
@ndmitchell
Copy link
Collaborator

We could continue to use ghcide as a submodule, just make sure we release syncronised? The flexibility of upgrading ghcide quickly seems like its currently pretty useful, so I'd be a bit sad to give that up.

@jneira
Copy link
Member

jneira commented Sep 15, 2020

Yeah, i overlooked it; just sync them will be enough

@jneira
Copy link
Member

jneira commented Nov 9, 2020

It turns out the next release (#567) will use the hackage ghcide version, so we could release hls to hackage (by coincidence this time so maybe it will be discontinued)

@jneira
Copy link
Member

jneira commented Nov 10, 2020

There is some discussion about the issue of the possible mismatch between the project ghc and the used on to compile hls: #567 (comment)

pepeiborra pushed a commit that referenced this issue Dec 27, 2020
…bust (#400)

* #381, require shake-0.18.5, which ensures progress cancelation is robust

* Fix a GHC 8.8.2 warning

* Don't allow-newer, do pin hie-bios
@jneira jneira mentioned this issue Jan 9, 2021
13 tasks
@jneira
Copy link
Member

jneira commented Mar 2, 2021

hls is already in hackage and we have too much extra-deps to upload to stackage in short/medium term so closing this
if anybody still thinks that upload to stackage would be good please open a new specific issue

@jneira jneira closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants