Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug that generating comments would duplicate existing comments #1233

Merged
merged 7 commits into from
Jan 20, 2021

Conversation

berberman
Copy link
Collaborator

screenshot before the fix:
Peek

@berberman berberman changed the title Fix the bug that generating signature comments would duplicate existing comments Fix the bug that generating comments would duplicate existing comments Jan 20, 2021
@berberman berberman marked this pull request as draft January 20, 2021 03:30
@berberman berberman marked this pull request as ready for review January 20, 2021 08:04
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tests are great!

@jneira jneira added the merge me Label to trigger pull request merge label Jan 20, 2021
@mergify mergify bot merged commit 2ad9eb0 into haskell:master Jan 20, 2021
@berberman berberman deleted the fix-haddock-comments branch January 20, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants