Bump plugins versions #1392
Merged
Bump plugins versions #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As proposed in #1310 |
|
Maybe hls-plugin-api should hide lsp to plugins (and ghcide?), with reexports or something, to cut at least in some cases the upgrade in cascade |
jneira
approved these changes
Feb 18, 2021
|
Updated also the minBounds in haskell-language-server.cabal. I am tempted to make these hard bounds ( |
|
please take a look to #1310 before merging |
|
@jneira What do you mean??? |
|
in that issue we were debating about bump up all project packages to 1.0 , in the face of a next hackage release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugins were all updated to lsp-1.0 in #1284 and need a minor version bump in order to be upload able to Hackage.
I am also going to upload all the plugins I have Hackage maintainer access (class, imports, and retrie). This is in order to make them usable with ghcide 0.7.5.0, which was released earlier today.
Ideally we would have a CI job that would detect Cabal version updates and automatically upload to Hackage.