Add support for brittany (needs aeson-2) and floskell with ghc-9.0.1

[jneira]

• It requires support for aeson-2 for ghc >= 9.0.1 but we have to keep aeson < 2.0 for older ghcs. It is done through a Compat module in hls-plugin-api
• It requires Upgrade to new version of lsp libraries #2494 as the new version of lsp libs supports aeson-2.0
• Closes Build with aeson >= 2.0 #2477

[michaelpj]

A few ideas: I think you could mostly get away without the CPP. The only one I'm stuck on is the adjustJson call...

[jneira]

I had to inline fromString cause ghc was not able to infer the type (tips on how to convince it appreciated)

[Ailrun]

Thank you for the update!

[jneira]

shake-bench also needs aeson-2 compatibility 🤦

[michaelpj]

i think i got it

yeah, looks great!

[michaelpj]

I'll take a look at shake-bench.

[jneira]

hmm dont know why but the error only is shown in the stack build:

shake-bench                       > /root/build/shake-bench/src/Development/Benchmark/Rules.hs:501:33: error:
shake-bench                       >     • Couldn't match type ‘Text’ with ‘Data.Aeson.Key.Key’
shake-bench                       >       Expected: GHC.Exts.Item
shake-bench                       >                   aeson-2.0.2.0:Data.Aeson.Types.Internal.Object
shake-bench                       >         Actual: (Text, Value)
shake-bench                       >     • In the pattern: (name, String gitName)
shake-bench                       >       In the pattern: [(name, String gitName)]
shake-bench                       >       In the pattern: toList -> [(name, String gitName)]
shake-bench                       >     |
shake-bench                       > 501 |   parseJSON (Object (toList -> [(name, String gitName)])) =
shake-bench                       >     |                                 ^^^^^^^^^^^^^^^^^^^^^^
shake-bench                       > 
shake-bench                       > /root/build/shake-bench/src/Development/Benchmark/Rules.hs:503:33: error:
shake-bench                       >     • Couldn't match type ‘Text’ with ‘Data.Aeson.Key.Key’
shake-bench                       >       Expected: GHC.Exts.Item
shake-bench                       >                   aeson-2.0.2.0:Data.Aeson.Types.Internal.Object
shake-bench                       >         Actual: (Text, Value)
shake-bench                       >     • In the pattern: (name, Object props)
shake-bench                       >       In the pattern: [(name, Object props)]
shake-bench                       >       In the pattern: toList -> [(name, Object props)]
shake-bench                       >     |
shake-bench                       > 503 |   parseJSON (Object (toList -> [(name, Object props)])) =
shake-bench                       >     |                                 ^^^^^^^^^^^^^^^^^^^^
shake-bench                       > 
shake-bench                       > /root/build/shake-bench/src/Development/Benchmark/Rules.hs:515:37: error:
shake-bench                       >     • Couldn't match type ‘Text’ with ‘Data.Aeson.Key.Key’
shake-bench                       >       Expected: GHC.Exts.Item
shake-bench                       >                   aeson-2.0.2.0:Data.Aeson.Types.Internal.Object
shake-bench                       >         Actual: (Text, Value)
shake-bench                       >     • In the expression: (n, String gitName)
shake-bench                       >       In the first argument of ‘fromList’, namely ‘[(n, String gitName)]’
shake-bench                       >       In the second argument of ‘($)’, namely
shake-bench                       >         ‘fromList [(n, String gitName)]’
shake-bench                       >     |
shake-bench                       > 515 |       Just n  -> Object $ fromList [(n, String gitName)]
shake-bench                       >     | 

[michaelpj]

Probably because we don't have benchmarks: true in cabal.project, so shake-bench gets built only if you ask for it.

[jneira]

Probably because we don't have benchmarks: true in cabal.project, so shake-bench gets built only if you ask for it.

i just did a cabal build --enable-benchmarks --project-file .\cabal-ghc901.project and it did not build shake-bench but a cabal build shake-bench --project-file .\cabal-ghc901.project worked. 🤷

[jneira]

Probably because we don't have benchmarks: true in cabal.project, so shake-bench gets built only if you ask for it.

i just did a cabal build --enable-benchmarks --project-file .\cabal-ghc901.project and it did not build shake-bench but a cabal build shake-bench --project-file .\cabal-ghc901.project worked. 🤷

due to haskell/cabal#6259 🤦

[michaelpj]

jneira#63

[jneira]

Wow that was fast, many thanks

[Ailrun]

This one is a fairly minor thing but the formatting is not applied

[jneira]

the new parsing in benchmarks is slighty different from the old one:

Error: Artifact path is not valid: /unprofiled/lsp-types/"upstream"/code_actions.csv. Contains the following character: Double quote "

[michaelpj]

the new parsing in benchmarks is slighty different from the old one

Ugh, I screwed up my string conversions trying to make them generic. I'll try again.

[michaelpj]

jneira#64

[jneira]

jneira#64

many thanks, lets see if ci is green here too ;-)

[jneira]

Ok it seems is ok to be merged, @michaelpj @Ailrun many thanks!

[michaelpj]

What a marathon lol

[michaelpj]

Mergify doesn't want to merge for some reason, but the checks are all green, so I'll hit the button.