Print info message when ignoring a file due to a none cradle #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
reviewed
Feb 10, 2022
| @@ -619,11 +621,15 @@ cradleToOptsAndLibDir logger cradle file = do | |||
| CradleFail err -> return (Left [err]) | |||
| -- For the None cradle perhaps we still want to report an Info | |||
There was a problem hiding this comment.
Now you're doing it, so you could get rid of these comments?
There was a problem hiding this comment.
Sure 👍 Fixed and squashed.
michaelpj
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Out of curiosity, I was investigating #2692.
From the debug logs, the
Left []gives the impression that we failed butnonecradles are correctly taken into account.This is a small patch to makes things a bit explicit for the user.