Add failing test for variables in hovers #2742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
approved these changes
Mar 1, 2022
pepeiborra
reviewed
Mar 1, 2022
| @@ -4165,6 +4166,11 @@ findDefinitionAndHoverTests = let | |||
| , test no yes outL45 outSig "top-level signature #767" | |||
| , test broken broken innL48 innSig "inner signature #767" | |||
| , test no yes holeL60 hleInfo "hole without internal name #831" | |||
| , if ghcVersion >= GHC92 then | |||
| -- Broken on GHC 9.2 and above due to printing of uniques | |||
| test no yes holeL65 [] "hole with variable" | |||
There was a problem hiding this comment.
I cannot remember what these parameters mean, but at least the 2nd or 3rd should be broken right?
There was a problem hiding this comment.
broken doesn't work there. I don't really understand how these work, so I just put an empty set of expectations...
michaelpj
force-pushed
the
mpj/hover-variables
branch
from
840b9d6
to
a8e238d
Compare
July541
pushed a commit
to July541/haskell-language-server
that referenced
this pull request
Mar 30, 2022
Witnesses haskell#2716. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Pepe Iborra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Witnesses #2716.