Actually enable pedantic flag in ci flags job #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
requested review from
michaelpj,
fendor,
santiweight and
drsooch
as code owners
fendor
requested changes
May 12, 2024
plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs
Outdated
Show resolved
Hide resolved
jhrcek
commented
May 13, 2024
jhrcek
commented
May 13, 2024
jhrcek
commented
May 13, 2024
| --constraint "ghcide +ekg +executable +test-exe" \ | ||
| --constraint "hls-plugin-api -use-fingertree" \ | ||
| --constraint "all +pedantic" |
There was a problem hiding this comment.
This all +pedantic did not have any effect - it needs to be enabled on per-cabal-file basis.
There was a problem hiding this comment.
Hm, do we expect this to work? Is there a cabal ticket discussing this behaviour?
There was a problem hiding this comment.
I didn't open any ticket about this in cabal, nor did I research why it doesn't work/whether it should work at all.
I just mistakenly assumed this works when I refactored this job.
Let me ask about it in cabal issue tracker later today.
There was a problem hiding this comment.
It turns out that the way to enable the flag for all local packages is via
cabal configure --flag pedantic
I'll make use of that in upcoming PR after I fix warnings in ghcide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #4223 we're not actually enabling pedantic in CI at all.
This enables it for all cabal projects for which most warnings have been fixed so far (not yet for ghcide).