-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get files from Shake VFS from within plugin handlers #4328
Merged
Merged
Commits on Jun 20, 2024
-
Change return type of getFileContents from Text to Rope
- This avoids a few conversions between Rope and Text in the next commit - Note: Syntactic changes to Development.IDE.Plugin.CodeAction around line 2000 are to work around the following stylish-haskell failure: plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs: <string>:2002:5: error: [GHC-58481] parse error (possibly incorrect indentation or mismatched brackets)
Configuration menu - View commit details
-
Copy full SHA for 2275959 - Browse repository at this point
Copy the full SHA 2275959View commit details -
Get virtual files from the Shake VFS in plugins
This commit changes plugins to get virtual files from the Shake VFS rather than from the language server's VFS. - Replace `Ide.Types.pluginGetVirtualFile` with `Development.IDE.Core.FileStore.getFileContents` - Replace `Ide.Types.pluginGetVersionedTextDoc` with `Development.IDE.Core.FileStore.getVersionedTextDoc`
Configuration menu - View commit details
-
Copy full SHA for 71ada5d - Browse repository at this point
Copy the full SHA 71ada5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ecab0d8 - Browse repository at this point
Copy the full SHA ecab0d8View commit details
Commits on Jun 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 579780a - Browse repository at this point
Copy the full SHA 579780aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 59292ee - Browse repository at this point
Copy the full SHA 59292eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cb9f15 - Browse repository at this point
Copy the full SHA 3cb9f15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99ee921 - Browse repository at this point
Copy the full SHA 99ee921View commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 87cfb3a - Browse repository at this point
Copy the full SHA 87cfb3aView commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a16fa46 - Browse repository at this point
Copy the full SHA a16fa46View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for afb0023 - Browse repository at this point
Copy the full SHA afb0023View commit details -
Install notification handlers for cabal files
The cabal formatters read the file contents from the shake VFS. Thus, we need to make sure there are notification handlers that add the cabal files to the VFS! Formatters have to depend on the `hls-cabal-plugin` to have the necessary notification handlers installed during test time.
Configuration menu - View commit details
-
Copy full SHA for 0b63299 - Browse repository at this point
Copy the full SHA 0b63299View commit details
Commits on Aug 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 972d993 - Browse repository at this point
Copy the full SHA 972d993View commit details
Commits on Sep 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be2adaf - Browse repository at this point
Copy the full SHA be2adafView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.