Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get files from Shake VFS from within plugin handlers #4328

Merged
merged 13 commits into from
Sep 28, 2024

Commits on Jun 20, 2024

  1. Change return type of getFileContents from Text to Rope

    - This avoids a few conversions between Rope and Text in the next commit
    - Note: Syntactic changes to Development.IDE.Plugin.CodeAction around line
      2000 are to work around the following stylish-haskell failure:
    
    plugins/hls-refactor-plugin/src/Development/IDE/Plugin/CodeAction.hs: <string>:2002:5:
    error: [GHC-58481]
        parse error (possibly incorrect indentation or mismatched brackets)
    awjchen committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2275959 View commit details
    Browse the repository at this point in the history
  2. Get virtual files from the Shake VFS in plugins

    This commit changes plugins to get virtual files from the Shake VFS
    rather than from the language server's VFS.
    
    - Replace `Ide.Types.pluginGetVirtualFile` with
      `Development.IDE.Core.FileStore.getFileContents`
    - Replace `Ide.Types.pluginGetVersionedTextDoc` with
      `Development.IDE.Core.FileStore.getVersionedTextDoc`
    awjchen committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    71ada5d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ecab0d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    579780a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    59292ee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cb9f15 View commit details
    Browse the repository at this point in the history
  4. Cleanup

    awjchen committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    99ee921 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Configuration menu
    Copy the full SHA
    87cfb3a View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Fix warning

    awjchen committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a16fa46 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Configuration menu
    Copy the full SHA
    afb0023 View commit details
    Browse the repository at this point in the history
  2. Install notification handlers for cabal files

    The cabal formatters read the file contents from the shake VFS. Thus, we
    need to make sure there are notification handlers that add the cabal
    files to the VFS!
    
    Formatters have to depend on the `hls-cabal-plugin` to have the
    necessary notification handlers installed during test time.
    fendor committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    0b63299 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    972d993 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    be2adaf View commit details
    Browse the repository at this point in the history