Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suggest -Wno-deferred-out-of-scope-variables #4441

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

jeukshi
Copy link
Contributor

@jeukshi jeukshi commented Oct 29, 2024

Fixes #4440

This does the trick, I don't get the code action on my local branch.

I'm just unsure if those tests do what they are supposed to do.

If I disable blacklist

warningBlacklist :: [T.Text]
warningBlacklist =
  -- Don't suggest disabling type errors as a solution to all type errors.
  [ --"deferred-type-errors"
  -- Don't suggest disabling out of scope errors as a solution to all out of scope errors.
  --, "deferred-out-of-scope-variables"
  ]

they do pass on my machine. The list is empty anyway, also in the case of deferred-type-errors. But that is beyond my current knowledge of the codebase.

Edit: fixed.

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!
One small issue, otherwise gtg!

plugins/hls-pragmas-plugin/test/Main.hs Outdated Show resolved Hide resolved
Fixes haskell#4440

Fixes test for disabling deferred-type-errors.
@jeukshi jeukshi force-pushed the wno-deferred-out-of-scope-variables branch from f335001 to f62d835 Compare October 29, 2024 15:09
@fendor fendor merged commit 96bea00 into haskell:master Nov 3, 2024
36 checks passed
soulomoon pushed a commit to soulomoon/haskell-language-server that referenced this pull request Nov 4, 2024
Fixes haskell#4440

Fixes test for disabling deferred-type-errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't suggest -Wno-deferred-out-of-scope-variables as a possible action.
3 participants