Use ghcide master head (d76fbf9)

[jneira]

• ghcide at d76fbf9
• minor changes needed in retrie, tactics and import plugins
• closes Use ghcide version with last TemplateHaskell improvements  #526

[jneira]

One test failing:

    local imports:                                                                                      FAIL
      Exception: Timed out waiting to receive a message from the server.
      Last message received:
      {
          "tag": "RspExecuteCommand",
          "contents": {
              "error": {
                  "code": -32603,
                  "message": "tried to look at linkable for GetModIfaceWithoutLinkable for NormalizedFilePath \"/home/runner/work/haskell-language-server/haskell-language-server/test/testdata/eval/T25.hs\"\nCallStack (from HasCallStack):\n  error, called at src/Development/IDE/Core/Rules.hs:836:79 in ghcide-0.4.0-inplace:Development.IDE.Core.Rules"
              },
              "jsonrpc": "2.0",
              "id": 2
          }
      }

The code to adapt the import plugin looks straightforwardIt is the eval plugin as noted below
//cc @wz1000

[wz1000]

hmm...

This is because the eval plugin uses GHC.load, which runs the compilation pipeline entirely in GHC, bypassing all our ghcide rules. It should ideally be using the bytecode we generate via ghcide rules. I think the NeedsCompilation logic in ghcide would also need to be somehow modified, in order to compile all files that use the eval plugin, or are dependencies of such a file.

/cc @pepeiborra

[wz1000]

Workaround for now would be to enable TemplateHaskell in any file that uses the eval plugin.

[jneira]

Let me know if you prefer merge this marking the test as knownBroken or we should wait to the eval plugin (and ghcide?) fix.

[wz1000]

I don't know, it completely breaks the eval plugin.

Lets wait for @pepeiborra to chime in.

[pepeiborra]

You can try to change the Eval plugin to use GhcSession instead of GhcSessionDeps. If that works, then merge this PR and look at converting it to use bytecode produced by ghcide later on.

[wz1000]

@jneira did you try changing GhcSessionDeps to GhcSession in the Eval plugin?

[jneira]

It is my next todo, but I have no time to start yet

[jneira]

@wz1000 i didnt expect it was so easy 😝
What are the actual implications of replace one for another?

[wz1000]

The Eval plugin will run a parallel compilation pipeline, loading all the modules independently of ghcide/hls.

[expipiplus1]

Would it be possible to get a release with this change?

[jneira]

@expipiplus1 yeah, it will be included in the incoming monthly release: #567
does it resolves some issue for you?

[expipiplus1]

Yeah, I had some weird issue with GHC throwing in initDs. Was talking about it with @wz1000 on IRC, this seemed to solve it.

[tittoassini]

Could this also be included?

haskell/ghcide@e922a16

It is a minimal change and is required to support CPP/LHS preprocessing in the Eval plugin.

[jneira]

@tittoassini the support is included simply updating ghcide? if it is the case i can give a try later at night, feel free to open a new pr updating ghcide again to get it sooner

[tittoassini]

Yes, it has already been merged in ghcide, just a matter of updating to the latest commit. Thanks! Il giorno mer 4 nov 2020 alle ore 13:23 Javier Neira < [email protected]> ha scritto:

…

@tittoassini <https://github.com/tittoassini> the support is included simply updating ghcide? if it is the case i can give a try later at night, feel free to open a new pr updating ghcide again to get it sooner — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#530 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAFRQK23G5354NPPDDBHWTSOFBVPANCNFSM4S4JG7ZA> .

-- Pasqualino "Titto" Assini http://networkpolitics.svbtle.com http://quid2.org/