Delete unused testdata #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is all dead code. It was brought over from haskell ide engine, but we don't use it. Note: We are deleting test/testdata/wrapper We are NOT deleting test/wrapper/testdata wrapper/testdata contains live testdata, which is being used to test that haskell-language-server-wrapper can load the appropriate version of haskell-language-server based on the environment that it is running in.
These are dead code, they are very simple so they aren't likely to be useful when writing new tests, and they have "HaRe" in the name even though HaRe is gone, which adds mental burden.
These all came over from Haskell IDE Engine, and we aren't using them. So lets clean up by deleting them.
jneira
reviewed
Dec 31, 2020
| @@ -1,4 +0,0 @@ | |||
| main = putStrLn "hello" | |||
There was a problem hiding this comment.
wow, i didnt notice those hlint tests and i wrote equivalent ones from zero 🤦
There was a problem hiding this comment.
Good reason to clean things up: so we can see what's there. :)
jneira
approved these changes
Dec 31, 2020
pepeiborra
added a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
* Delete test/testdata/wrapper/*. This is all dead code. It was brought over from haskell ide engine, but we don't use it. Note: We are deleting test/testdata/wrapper We are NOT deleting test/wrapper/testdata wrapper/testdata contains live testdata, which is being used to test that haskell-language-server-wrapper can load the appropriate version of haskell-language-server based on the environment that it is running in. * Delete HaRe test files. These are dead code, they are very simple so they aren't likely to be useful when writing new tests, and they have "HaRe" in the name even though HaRe is gone, which adds mental burden. * Delete unused test datafiles. These all came over from Haskell IDE Engine, and we aren't using them. So lets clean up by deleting them. Co-authored-by: Javier Neira <[email protected]> Co-authored-by: Pepe Iborra <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete a bunch of unused test data that came over from HIE.