Delete unused utilities for controlling logging. #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete withFileLogging, logConfig, and noLogConfig. Logging is turned on by hlsCommand. Should we ever want to disable it for a certain test, we would create a new version of hlsCommand, say, hlsCommandNoLog.
jneira
approved these changes
Dec 31, 2020
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
* Delete unused utilities for controlling logging. Delete withFileLogging, logConfig, and noLogConfig. Logging is turned on by hlsCommand. Should we ever want to disable it for a certain test, we would create a new version of hlsCommand, say, hlsCommandNoLog. * Delete unused import. Co-authored-by: Javier Neira <[email protected]> Co-authored-by: Junyoung Clare Jang <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete withFileLogging, logConfig, and noLogConfig.
Logging is turned on by hlsCommand. Should we ever want to disable it for a
certain test, we would create a new version of hlsCommand, say, hlsCommandNoLog.