Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aeson 2 compatibility #360

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Aeson 2 compatibility #360

merged 1 commit into from
Nov 2, 2021

Conversation

michaelpj
Copy link
Collaborator

We get compatibility with both <2 and >=2 by using only functions that
appear in both, which don't make assumptions about the structure of
objects.

Fixes #356

We get compatibility with both <2 and >=2 by using only functions that
appear in both, which don't make assumptions about the structure of
objects.

Fixes haskell#356
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and elegant with no CPP conditions (with only some scary lens-like operators in exchange :-P)

@fendor do you think we could remove cpp conditions from hie-bios as well?

@michaelpj
Copy link
Collaborator Author

Oh and just to confirm: I built this with both versions 1.5.6 and 2.0.1, so it does definitely build with both.

@fendor
Copy link
Collaborator

fendor commented Oct 31, 2021

Looks great and elegant with no CPP conditions (with only some scary lens-like operators in exchange :-P)

@fendor do you think we could remove cpp conditions from hie-bios as well?

Sounds like a good idea, will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aeson >= 2.0.0.0 causes a build failure
3 participants