Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for advisory parsing #100

Closed
frasertweedale opened this issue Jul 22, 2023 · 1 comment · Fixed by #105
Closed

add tests for advisory parsing #100

frasertweedale opened this issue Jul 22, 2023 · 1 comment · Fixed by #105
Assignees
@TristanCacqueray

Comments

@frasertweedale
Copy link
Collaborator

frasertweedale commented Jul 22, 2023 •
edited
Loading

Before we merge #88, we need to add regression tests for advisory parsing. Example-based tests will be fine, and we should test various success scenarios (in particular: presence/absence of optional fields) as well as common failure scenarios.
@frasertweedale frasertweedale mentioned this issue Jul 23, 2023
Closed
@TristanCacqueray
Copy link
Collaborator

I can give this a try, have you started the work?

TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
b4b06a8 
Fixes haskell#100
@TristanCacqueray TristanCacqueray mentioned this issue Jul 24, 2023
Merged
TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
4e331f1 
Fixes haskell#100
TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
9602566 
Fixes haskell#100
TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
a2a6a59 
Fixes haskell#100
TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
ddc411c 
Fixes haskell#100
TristanCacqueray added a commit to TristanCacqueray/security-advisories that referenced this issue Jul 24, 2023
@TristanCacqueray
tools: add golden tests to validate the parser
b6b61a3 
Fixes haskell#100
frasertweedale pushed a commit that referenced this issue Aug 23, 2023
@TristanCacqueray @frasertweedale
tools: add golden tests to validate the parser
c281658 
Fixes #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TristanCacqueray TristanCacqueray

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: add golden tests to validate the parser TristanCacqueray/security-advisories
2 participants
@TristanCacqueray @frasertweedale