Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: check HSEC id uniqueness #38

Merged
merged 1 commit into from
Jun 13, 2023
Merged

ci: check HSEC id uniqueness #38

merged 1 commit into from
Jun 13, 2023

Conversation

frasertweedale
Copy link
Collaborator

Add a CI check that HSEC ids (or the filenames, at least) are unique.

I pushed a branch with a conflict to test the new CI step. Result:
https://github.com/frasertweedale/security-advisories/actions/runs/5251623664/jobs/9486797411

@frasertweedale frasertweedale mentioned this pull request Jun 13, 2023
Merged
3 tasks
@blackheaven
Copy link
Collaborator

I think we should also check toml's id too

@frasertweedale
Copy link
Collaborator Author

I think we should also check toml's id too

I plan on adding this to the hsec-tools check command (will change it to read a named file, instead of stdin). So that will be done in a separate PR, when I (or someone else) get to it.

@frasertweedale frasertweedale merged commit ac008a7 into haskell:main Jun 13, 2023
@frasertweedale frasertweedale deleted the ci/adv-id-uniqueness branch June 13, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackheaven blackheaven blackheaven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frasertweedale @blackheaven