Tooling update #1043
Merged
Tooling update #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzm3r
commented
Feb 7, 2024
•
bzm3r
commented
- Use ESLint instead of TSLint (deprecated TSLint is deprecated #1042)
- Address ESLint suggestions
- Add prettier to workspace recommendations (not clear how to make it the default formatter for relevant files however)
…ey seem reasonable...
…warning are also being correctly suppressed
|
I'm not sure why the test is failing on MacOS. Also, I am not sure how worthwhile this PR is. |
|
Likely a flaky failure and not a real issue.
Why not? Are we missing something? I think the PR looks pretty good. |
|
Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.