Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message for 403 error on API access #139

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

davet2001
Copy link
Contributor

@davet2001 davet2001 commented Sep 26, 2023

Proposed Changes

(Describe the changes and rationale behind them)

When trying to develop an addon, I got messages like this appearing in the logs of the addon:

parse error: Expected string key before ':' at line 1, column 4

When all I was doing was:

HOST=$(bashio::host)

It turned out this was caused by a jq statement trying to parse the string

403: Forbidden

By adding this extra error message, we give developers a bit more of a hint as to what is wrong.

Related Issues

(Github link to related issues or pull requests)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davet2001 👍

../Frenck

@frenck frenck merged commit 2f86c63 into hassio-addons:main Oct 22, 2023
4 checks passed
@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Oct 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@davet2001 davet2001 deleted the patch-1 branch December 28, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants