Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value handling for configuration options #90

Merged
merged 1 commit into from
Nov 10, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
#
# Arguments:
# $1 Key of the config option
# $2 Default value for not set config option (optional: defaults to 'null')
# ------------------------------------------------------------------------------
function bashio::config() {
local key=${1}
local default_value=${2:-}
local default_value=${2:-null}
local query
local result

Expand Down Expand Up @@ -48,7 +49,7 @@ QUERY
options=$(bashio::addon.config)
result=$(bashio::jq "${options}" "${query}")

if [[ "${result}" == "null" ]] && bashio::var.has_value "${default_value}";
if [[ "${result}" == "null" ]];
then
echo "${default_value}"
else
Expand Down