Fix processing of empty add-on config #91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bashio handles
{}
as an empty value. This works nicely when working with Bash, as it doesn't handle dictionaries that well.In the case of fetching the full configuration from the Supervisor API, this may lead to a surprising issue. If there is no add-on configuration, it returns
{}
is handled as empty by Bashio.When later processing values from the empty config,
jq
simply returns empty results 🤷To prevent these issues, I've added a small check to ensure we return an empty JSON object when there is no add-on configuration.
This makes Bashio behave exactly the same as with the previous
options.json
method.